Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and determine requirements for chain ID format #759

Open
lumtis opened this issue May 4, 2022 · 0 comments
Open

Investigate and determine requirements for chain ID format #759

lumtis opened this issue May 4, 2022 · 0 comments

Comments

@lumtis
Copy link
Contributor

lumtis commented May 4, 2022

We enforce for chains to follow a format: [chain-name]-[revision-number] for the chain ID

https://github.com/tendermint/spn/tree/develop/pkg/chainid

We have other projects that can enforce other restrictions incompatible with our imposed format:
Ex Evmos:
https://github.com/tharsis/ethermint/blob/main/types/chain_id.go
https://github.com/tharsis/ethermint/blob/93d15db4d086d65eb0a7bee744b453e5ae416ac0/types/chain_id_test.go#L19

We should investigate and make our chain ID format less restrictive to support these project launches

The requirement for the chain ID format is that we can create an IBC client with it. It passes the chain ID verification in client creation https://github.com/cosmos/ibc-go/blob/f5962c3324ee7e69eeaa9918b65eb1b089da6095/modules/light-clients/07-tendermint/types/client_state.go#L99
@lumtis lumtis added this to the Milestone B milestone May 9, 2022
@lumtis lumtis removed this from the Milestone B milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lumtis