Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation test: high failure rates for some operations for some flag values #368

Closed
lumtis opened this issue Oct 27, 2021 · 2 comments
Closed
Labels
test Improve tests

Comments

@lumtis
Copy link
Contributor

lumtis commented Oct 27, 2021

Describe the bug
When setting the FlagNumBlocksValue and FlagBlockSizeValue to different values in app/simulation_test.go. Some operations might sometimes have very high failure rates. Example are:

update_total_shares
update_total_supply
request_remove_account
request_remove_validator

I think changing the flag values modify the seed used for the simulation and therefore the state of the app will be different. The high failure rates might be related to flaws in our methods to fetch the state (FindChain, FindCampaign) that fails to find values for specific configurations of the state of the app.
We must investigate this

@lumtis
Copy link
Contributor Author

lumtis commented Oct 27, 2021

Based on the operation I listed above. The flawed methods might be GetCoordSimAccountWithCampaignID and FindRandomRequest

@lumtis lumtis added the test Improve tests label Nov 18, 2021
@lumtis
Copy link
Contributor Author

lumtis commented Apr 13, 2022

Closing in favor of #716

@lumtis lumtis closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Improve tests
Projects
None yet
Development

No branches or pull requests

1 participant