Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local notification to open Bitkit #2094

Closed
JeanlChristophe opened this issue Jul 25, 2024 · 6 comments · Fixed by #2135 or #2167
Closed

Local notification to open Bitkit #2094

JeanlChristophe opened this issue Jul 25, 2024 · 6 comments · Fixed by #2135 or #2167
Assignees
Labels
estimate:8 high priority This should be worked on urgently

Comments

@JeanlChristophe
Copy link

JeanlChristophe commented Jul 25, 2024

Description

When a user makes a request to open a channel, the user must come back to the app in between the time the channel is ready to be opened and before channel expiry. However, since the transaction can take several hours or even several days some users may forget and miss the time window, ending up with an expired channel order.

The problem is that the BT order is only valid for 2 days. We therefore need to warn the user to open Bitkit.

Ex: https://synonymworkspace.slack.com/archives/C0726U60V6Y/p1721769530317439

Solution
Schedule local notifications telling the user that he must open Bitkit in order to continue the channel opening process.

  • First notification after 24 hours
  • Second notification after 40 hours (this notification will not be shown if the channel was opened before then)

Note:
We don't check if the channel purchase transaction actually got confirmed (will be solved with wakeToOpen), so there can be the case where fees are spiking and the transaction doesn't confirm before order expiry. In this case the notifications will still (falsely) appear.

@aldertnl
Copy link
Contributor

image

@pwltr pwltr assigned pwltr and unassigned aldertnl Jul 29, 2024
@JeanlChristophe
Copy link
Author

First: after 24h
Second: After 40h

@JeanlChristophe JeanlChristophe added estimate:8 high priority This should be worked on urgently labels Aug 8, 2024
@pwltr
Copy link
Collaborator

pwltr commented Aug 13, 2024

Updated description to better explain the problem and implementation

@JeanlChristophe
Copy link
Author

I received a notification 24h after on my phone. But Once I clicked on it, nothing happened. I needed to open myself Bitkit.

@pwltr
Copy link
Collaborator

pwltr commented Aug 27, 2024

The changes from the stealth mode feature did break this on Android. If we end up reverting that feature this will be resolved.

@JeanlChristophe
Copy link
Author

Yes, during the dev call Johna said we were killing this feature, right?

@pwltr pwltr linked a pull request Aug 28, 2024 that will close this issue
@pwltr pwltr changed the title Push notification to open Bitkit Local notification to open Bitkit Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:8 high priority This should be worked on urgently
Projects
None yet
3 participants