Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment coverage of cid-verifier #65

Open
vasco-santos opened this issue Sep 13, 2022 · 2 comments
Open

Augment coverage of cid-verifier #65

vasco-santos opened this issue Sep 13, 2022 · 2 comments
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature pi/malware-mitigation

Comments

@vasco-santos
Copy link
Contributor

in cid-verifier, more coverage with different score types / confidence levels. Inspect KV, trigger concurrent requests in parallel and inspect KV, status codes

@vasco-santos vasco-santos added the kind/enhancement A net-new feature or improvement to an existing feature label Sep 13, 2022
@vasco-santos
Copy link
Contributor Author

@jsdevel I recently got to know about fetchMock support in Miniflare https://miniflare.dev/core/standards#mocking-outbound-fetch-requests

Perhaps it will be easier and more scoped for the tests to use this to mock calls to google evaluate API instead of using Smoke and have a bunch of IFs there that are not clear to where they are needed. What do you think?

@jsdevel
Copy link
Contributor

jsdevel commented Sep 20, 2022

@jsdevel I recently got to know about fetchMock support in Miniflare https://miniflare.dev/core/standards#mocking-outbound-fetch-requests

Perhaps it will be easier and more scoped for the tests to use this to mock calls to google evaluate API instead of using Smoke and have a bunch of IFs there that are not clear to where they are needed. What do you think?

I'll check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature pi/malware-mitigation
Projects
None yet
Development

No branches or pull requests

2 participants