Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U237 Breaking Changes #287

Open
7 tasks
vadcx opened this issue Jun 13, 2023 · 6 comments
Open
7 tasks

U237 Breaking Changes #287

vadcx opened this issue Jun 13, 2023 · 6 comments

Comments

@vadcx
Copy link
Contributor

vadcx commented Jun 13, 2023

I don't know what you have pushed in the release version, because you didn't update the repository ;) I finished reviewing the diff between U237 and the older version.

Feel free to edit to mark completion:

  • Rich presence changed to support both Epic, Steam: WinPlatformManager:set_rich_presence(name)
    relevant: local is_epic, local is_mm_eos
    Steam Matchmaking still exists side-by-side and can be enabled with -steamMM startup argument (tested and it really works on Steam, idk about EGS)

  • Overlay open url function renamed: Steam:overlay_activatemanagers.network.account:overlay_activate

  • peer:user_id() changed to peer:account_id() everywhere?

  • lobby searching function changed from taking room.owner_id to room

  • Steam:username(user_id) to peer:name()

  • Steam:userid() to managers.network.account:player_id() - search for steam_id

  • Checking for friend status should respect SocialHub


Misc notes:

  • These are O(n) again, dangerous: NetworkAccount:is_player_friend + NetworkAccountSTEAM:get_friend_user + NetworkAccountSTEAM:is_player_friend

Did one of these changes break ForceReady?

@steam-test1
Copy link
Owner

Updated the lua
Force ready contains references to Steam:friends which need to be replaced

@vadcx
Copy link
Contributor Author

vadcx commented Jun 13, 2023

Ok thanks, lots of changes already! I'll take a look tomorrow.

😭 49495bd#diff-84595b858ab78c5242e39515aff8bb6dff0b7ef519fd5b39ca4c67e95dca3193L1 I specifically extracted it into a separate file so it could be disabled by commenting out the include (ForceReady.lua), alternatively by doing if false and ... on the first line 😂

Anyway, I will fix ForceReady and check/rewrite the crimenet performance fix completely if its still needed.

@Arlwe
Copy link

Arlwe commented Jun 17, 2023

I also have the problem of vanilla not appearing in mods options, try to say in modworkshop and I got no answers. Any suggestions?

@steam-test1
Copy link
Owner

I also have the problem of vanilla not appearing in mods options, try to say in modworkshop and I got no answers. Any suggestions?

Try looking at mods/logs and search for fatal error

@Arlwe
Copy link

Arlwe commented Jun 18, 2023

I also have the problem of vanilla not appearing in mods options, try to say in modworkshop and I got no answers. Any suggestions?

Try looking at mods/logs and search for fatal error

I figured it out, turns out I changed the language (Doing so change the options from its place) Didn't notice until know. Thank you anyways

@steam-test1
Copy link
Owner

Ok thanks, lots of changes already! I'll take a look tomorrow.

😭 49495bd#diff-84595b858ab78c5242e39515aff8bb6dff0b7ef519fd5b39ca4c67e95dca3193L1 I specifically extracted it into a separate file so it could be disabled by commenting out the include (ForceReady.lua), alternatively by doing if false and ... on the first line 😂

Anyway, I will fix ForceReady and check/rewrite the crimenet performance fix completely if its still needed.

I fixed crimenet performance and force ready in the latest auto update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants