From ff011af2498f7d3d77c062768b31ac5fa443bbc1 Mon Sep 17 00:00:00 2001 From: Stan Rozenraukh Date: Sat, 22 Jul 2023 10:52:53 -0400 Subject: [PATCH 1/2] some js cleanup --- frontend/components/DiffBlock.vue | 10 +++------- frontend/pages/index.vue | 10 +++++----- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/frontend/components/DiffBlock.vue b/frontend/components/DiffBlock.vue index 5846fa5..23a076b 100644 --- a/frontend/components/DiffBlock.vue +++ b/frontend/components/DiffBlock.vue @@ -46,17 +46,13 @@ const languageMap = { Dockerfile: 'docker' }; -function basename(str, sep) { - return str.substr(str.lastIndexOf(sep) + 1); -} - -function detectedLanguage(path) { +const basename = (str, sep) => str.substr(str.lastIndexOf(sep) + 1); +const detectedLanguage = (path) => { // basename and split on extension... const base = basename(path, '/'); const pieces = base.split('.'); const ext = pieces[pieces.length - 1]; - // if there's an extension go the standard path if (pieces.length > 1) { return languageMap[ext] || ext; @@ -67,7 +63,7 @@ function detectedLanguage(path) { } return 'bash'; -} +}; const language = computed(() => { return `diff-highlight language-diff-${detectedLanguage(props.comment.path)}`; diff --git a/frontend/pages/index.vue b/frontend/pages/index.vue index fa769ed..1477582 100644 --- a/frontend/pages/index.vue +++ b/frontend/pages/index.vue @@ -61,20 +61,20 @@ const query = ref(''), errorMessage = ref(''), searchDisabled = ref(false); -function searchLoading() { +const searchLoading = () => { searchDisabled.value = true; errorMessage.value = ''; -} +}; -function searchError(msg) { +const searchError = (msg) => { searchDisabled.value = false; errorMessage.value = msg; -} +}; async function search() { searchLoading(); - setTimeout(async function() { + setTimeout(async () => { const { data, error } = await useFetch('/api/search', { params: { search: query.value }, server: false, From 79f85b31acea02c501403601ff6a25654038738d Mon Sep 17 00:00:00 2001 From: Stan Rozenraukh Date: Sat, 22 Jul 2023 11:02:29 -0400 Subject: [PATCH 2/2] w/ prettier --- frontend/.eslintrc.cjs | 18 +- frontend/components/BodyMarkdown.vue | 6 +- frontend/components/CommentCard.vue | 8 +- frontend/components/ComponentCard.vue | 7 +- frontend/components/DiffBlock.vue | 179 +- frontend/components/ErrorMessage.vue | 5 +- frontend/components/GradientText.vue | 4 +- frontend/components/MarkdownHTML.vue | 6 +- frontend/components/Review/MetadataList.vue | 18 +- frontend/components/Review/PageChrome.vue | 34 +- frontend/components/Review/PageContent.vue | 2 +- frontend/components/ReviewLink.vue | 5 +- frontend/components/SearchBox.vue | 44 +- frontend/components/SlideCard.vue | 4 +- frontend/components/SlideShow.vue | 21 +- frontend/components/SmallBadge.vue | 3 +- frontend/components/TopBar.vue | 8 +- frontend/error.vue | 4 +- frontend/layouts/default.vue | 15 +- frontend/nuxt.config.ts | 14 +- frontend/package.json | 9 +- .../[repo]/pull/[pull]/[review]/index.vue | 4 +- .../[org]/[repo]/pull/[pull]/[review]/md.vue | 4 +- .../[repo]/pull/[pull]/[review]/post.vue | 4 +- .../[repo]/pull/[pull]/[review]/slides.vue | 4 +- .../pull/[pull]/review-[review]/slides.vue | 5 +- frontend/pages/index.vue | 98 +- frontend/tailwind.config.js | 2 +- frontend/yarn.lock | 1792 ++++++++++++++++- 29 files changed, 2042 insertions(+), 285 deletions(-) diff --git a/frontend/.eslintrc.cjs b/frontend/.eslintrc.cjs index 19ea4cf..14e7685 100644 --- a/frontend/.eslintrc.cjs +++ b/frontend/.eslintrc.cjs @@ -1,15 +1,17 @@ module.exports = { root: true, - extends: ["@nuxt/eslint-config"], + parser: "vue-eslint-parser", + parserOptions: { + parser: "@typescript-eslint/parser", + }, + extends: ["@nuxt/eslint-config", "plugin:prettier/recommended"], rules: { - "vue/max-attributes-per-line": ["error", { - "singleline": { - "max": 2 - }, - "multiline": { - "max": 3 + "vue/max-attributes-per-line": [ + "error", { + "singleline": { "max": 4 }, + "multiline": { "max": 4 } } - }], + ], }, overrides: [ { diff --git a/frontend/components/BodyMarkdown.vue b/frontend/components/BodyMarkdown.vue index 4e919df..8938741 100644 --- a/frontend/components/BodyMarkdown.vue +++ b/frontend/components/BodyMarkdown.vue @@ -8,12 +8,12 @@ diff --git a/frontend/components/CommentCard.vue b/frontend/components/CommentCard.vue index 586e493..2b8bead 100644 --- a/frontend/components/CommentCard.vue +++ b/frontend/components/CommentCard.vue @@ -8,7 +8,9 @@
{{ commentBody }}
-
+
@@ -19,10 +21,10 @@ diff --git a/frontend/components/ComponentCard.vue b/frontend/components/ComponentCard.vue index 7976ca2..473c0b3 100644 --- a/frontend/components/ComponentCard.vue +++ b/frontend/components/ComponentCard.vue @@ -1,7 +1,10 @@ diff --git a/frontend/components/Review/MetadataList.vue b/frontend/components/Review/MetadataList.vue index 6cc8425..51a6580 100644 --- a/frontend/components/Review/MetadataList.vue +++ b/frontend/components/Review/MetadataList.vue @@ -1,7 +1,8 @@