Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data model factory class need refactoring #5

Open
rajiff opened this issue Aug 22, 2016 · 0 comments
Open

Data model factory class need refactoring #5

rajiff opened this issue Aug 22, 2016 · 0 comments
Assignees
@pfarkya

Comments

@rajiff
Copy link
Collaborator

rajiff commented Aug 22, 2016

  • Many methods for obtaining config data for the data model definition page, instead try keeping it one single config data request to server and try to cache it as well
  • Separate angular component definitions into a separate folder & file, you can name them "ngcomponent"
  • Not enough code comments, please capture the thought process in code comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfarkya pfarkya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rajiff @pfarkya