Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cosign rsa keys #416

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Nov 12, 2021

Fixes #201

Description

  • support of rsa public keys for cosign validator is added

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #416 (7a6c16e) into develop (b7b2f05) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #416      +/-   ##
===========================================
+ Coverage    94.45%   94.52%   +0.06%     
===========================================
  Files           22       22              
  Lines         1101     1114      +13     
===========================================
+ Hits          1040     1053      +13     
  Misses          61       61              
Impacted Files Coverage Δ
connaisseur/crypto.py 100.00% <100.00%> (ø)
connaisseur/validators/cosign/cosign_validator.py 98.91% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b2f05...7a6c16e. Read the comment docs.

@xopham xopham force-pushed the feat/support-cosign-rsa-keys branch 4 times, most recently from 7a6c16e to 09b727c Compare November 14, 2021 20:10
@timothy-spencer
Copy link
Contributor

Any motion on this? I'm trying to use the pubkey half of an AWS kms asymmetric key, and it keeps saying The trust_root type <class 'connaisseur.trust_root.RSAKey'> is unsupported for a validator of typecosign. I can verify using cosign and this pubkey by hand, but connaisseur is saying NOPE. Seems like this would fix that.

@phbelitz
Copy link
Member

@timothy-spencer i will have a look next week 🥸

@phbelitz phbelitz force-pushed the feat/support-cosign-rsa-keys branch 2 times, most recently from 447025a to 64cea52 Compare June 26, 2023 10:11
@phbelitz phbelitz marked this pull request as ready for review June 26, 2023 10:16
Makefile Show resolved Hide resolved
tests/test_trust_root.py Outdated Show resolved Hide resolved
phbelitz and others added 2 commits June 27, 2023 15:53
as of v1.3.0, cosign allows verifying signatures using RSA instead of ECDSA. this is integrated via the rsa package.

fixes #201

Co-authored-by: Ivan Wallis <iwallis@gmail.com>
@phbelitz phbelitz force-pushed the feat/support-cosign-rsa-keys branch from 64cea52 to 6fdcbde Compare June 27, 2023 13:54
@phbelitz phbelitz merged commit 6fdcbde into develop Jun 27, 2023
47 of 49 checks passed
@phbelitz phbelitz deleted the feat/support-cosign-rsa-keys branch June 27, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants