Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed k8-keychain renaming #1772

Merged
merged 1 commit into from
Sep 27, 2024
Merged

docs: fixed k8-keychain renaming #1772

merged 1 commit into from
Sep 27, 2024

Conversation

phbelitz
Copy link
Member

The --k8-keychain feature provided by cosign is supported by Connaisseur with the auth.k8sKeychain option in validator configurations. This option was internally renamed to auth.useKeychain without mentioning this change inside the documentation. This has been fixed.

fixes #1766

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

Starkteetje
Starkteetje previously approved these changes Sep 27, 2024
@Starkteetje Starkteetje dismissed their stale review September 27, 2024 08:45

More places to fix

Copy link
Member

@Starkteetje Starkteetje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also adapt the upgradeToV3 script to fix this

The `--k8-keychain` feature provided by cosign is supported by Connaisseur with the `auth.k8sKeychain` option in validator configurations. This option was internally renamed to `auth.useKeychain` without mentioning this change inside the documentation. This has been fixed.

fixes #1766
@phbelitz phbelitz merged commit 6233669 into develop Sep 27, 2024
51 checks passed
@phbelitz phbelitz deleted the docs/keychain branch September 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants