Reader SDK version bump to 1.7.4 #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you also need to update the |
|
Nit: if we're going to bother with the overall-commit template, we should fill it in. |
fka3
reviewed
Sep 18, 2024
...k-react-native-quickstart/android/app/src/main/java/com/rnreadersdksample/MainApplication.kt
Outdated
Show resolved
Hide resolved
brandonjenniges
requested changes
Sep 23, 2024
| ### v1.4.5 Apr 25, 2024 | ||
|
|
||
| * Upgrade Reader SDK version support to 1.7.2 for iOS | ||
|
|
||
| ### v1.4.4 Aug 16, 2023 | ||
|
|
||
| * Upgrade Reader SDK version support to 1.7.5 for Android | ||
| * Support CompileSDK and targetSDK 33 on Android | ||
| * Upgrade Reader SDK version support to 1.7.7 for Android |
There was a problem hiding this comment.
I don't think you should be updating the previous changelog. All of the changes should be for the newest entry.
| @@ -1,13 +1,17 @@ | |||
| ## Changelog | |||
|
|
|||
| ### v1.4.6 Sep 18, 2024 | |||
There was a problem hiding this comment.
This should be v1.7.7 right? That's what this is updating it to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Fix #
Changelog
Test Plan