Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jackson 2.8.11.20180217 #11475

Closed
wilkinsona opened this issue Jan 3, 2018 · 14 comments
Closed

Upgrade to Jackson 2.8.11.20180217 #11475

wilkinsona opened this issue Jan 3, 2018 · 14 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added this to the 1.5.10 milestone Jan 3, 2018
@wilkinsona
Copy link
Member Author

wilkinsona commented Jan 4, 2018

This is causing some problems with Spring Security. Let's revert for now, but revisit the upgrade before 1.5.10 is released.

@wilkinsona wilkinsona reopened this Jan 4, 2018
wilkinsona added a commit that referenced this issue Jan 4, 2018
@wilkinsona
Copy link
Member Author

There was rumour of a Jackson 2.8.11.1 that addressed the problems @rwinch encountered but it has yet to appear. Rob's going to review the situation with Security. The chances are that we'll need to defer this to 1.5.11 once he's had a chance to figure out how to work around the breaking changes.

@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Jan 29, 2018
@wilkinsona wilkinsona modified the milestones: 1.5.10, 1.5.11 Jan 30, 2018
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Jan 30, 2018
@wilkinsona
Copy link
Member Author

The current plan is to upgrade Boot in 1.5.11 and consume Spring Security 4.2.5 that also upgrades at the same time.

@vdotjansen
Copy link

I am happy to see this is planned as our (owasp) dependency checker warns us about using jackson 2.8.10, because it contains a vulnerability.
https://nvd.nist.gov/vuln/detail/CVE-2017-17485

@wilkinsona
Copy link
Member Author

There’s some interesting background on the Jackson vulnerability here. The TL;DR is that you will not be vulnerable unless your app does something out of the ordinary. Boot itself does not.

@matan504
Copy link

matan504 commented Feb 5, 2018

Happy to see that there is a live discussion about this and that it is being addressed :)

@ckotzbauer
Copy link

Are there also plans to upgrade to 2.9.4+ before 2.0.0 goes final?

@rwinch
Copy link
Member

rwinch commented Feb 6, 2018

@code-chris Spring Boot 2.0 updated to Jackson 2.9.4 in #11830 The changes are present in the current SNAPSHOTs.

@ckotzbauer
Copy link

great. Thanks @rwinch

@Konstantinos-Mavridis
Copy link

Konstantinos-Mavridis commented Feb 16, 2018

Jackson 2.8.11 also contains a vulnerability (https://nvd.nist.gov/vuln/detail/CVE-2018-5968). It's better to upgrade straight to the micro-patch 2.8.11.1 which addresses it via issue FasterXML/jackson-databind#1899 (https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8)

@wilkinsona
Copy link
Member Author

Unfortunately we can't (easily) do that until Jackson's bom has been updated. I've opened FasterXML/jackson-bom#11.

@wilkinsona
Copy link
Member Author

It's also worth noting that 2.8.11 isn't vulnerable by default. You have to be using Jackson in a particular way to be affected. Spring Boot itself does not do so. This blog post by @cowtowncoder is well worth reading if you haven't already done so.

@matan504
Copy link

wilkinsona, you are probably right, but the sad truth is that this sort of answer is not acceptable by the organizations that utilize our products and self-scan them for vulnerabilities. They require such versions to be removed\changed in their entirety.

@cowtowncoder
Copy link

@matan504 Perhaps it would be worth pointing out this fundamental problemn wrt naivistic scanners to organizations, for longer term improvement. There needs to be a way to indicate potential problems that require specific configuration to enable.

@wilkinsona wilkinsona changed the title Upgrade to Jackson 2.8.11 Upgrade to Jackson 2.8.11.20180217 Feb 19, 2018
@wilkinsona wilkinsona self-assigned this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

7 participants