You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure we should call void and not sure about invalidate either tbh. But we should have in mind that void we'll try to hit Adyen and actually void a payment that might not even have succeeded in the first place. I think thats why I decided to go with invalidate here.
I can imagine that decision being very particular to each store though. Perhaps instead of changing the payment state the safer and most efficient thing to do here would be to email store staff to take be aware theres a failing payment.
Either way thanks a ton for noticing the state bug. I'm thinking about leaving that as is right now while we dont come up with a proper solution because at least an exception will be raise and someone should notice that something has gone wrong.
When adyen sends a non successful notification e.g. cancel a payment the following code is triggered:
Now if you look at the state machine code in payment.rb ( spree core )
It looks as though we should be calling void rather than invalidate ? or am I missing something?
The text was updated successfully, but these errors were encountered: