Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve viewer menu #324

Closed
yungyuc opened this issue Apr 28, 2024 · 4 comments · Fixed by #356 or #360
Closed

Improve viewer menu #324

yungyuc opened this issue Apr 28, 2024 · 4 comments · Fixed by #356 or #360
Assignees
@yungyuc
Labels
enhancement New feature or request viewer Visualize stuff
Milestone
GUI with first-cl...

Comments

@yungyuc
Copy link
Member

yungyuc commented Apr 28, 2024 •
edited
Loading

The viewer menu should be redesigned. In contrast to the current 5 menus

image

there should be 6 menus in the menu bar:

image

The hierarchical list of the menu items:

  • File
    • Load mesh file
  • View (the original Camera)
    • Orbit camera
    • First-person camera
  • One (the original Euler)
    • Load Euler
  • Mesh
    • Load NACA airfoil
    • Sample meshes
  • Add-on (the original App)
    • (Empty for now)
  • Windows
    • (Empty for now)

A new add-on/plug-in system will be implemented and the add-ons/plug-ins should be placed under the Add-on menu.
@yungyuc yungyuc added viewer Visualize stuff mesh Spatial mesh labels Apr 28, 2024
@yungyuc yungyuc mentioned this issue Jun 7, 2024
Closed
@yungyuc yungyuc changed the title Improve viewer "Mesh" menu Improve viewer menu Jun 7, 2024
@yungyuc yungyuc mentioned this issue Jun 7, 2024
Open
yungyuc added a commit to yungyuc/modmesh that referenced this issue Jun 8, 2024
@yungyuc
Reorder menu bar
bad566e 
Following the description in solvcon#324, rename "Euler" to "One", "Camera" to "View", and "App" to "Add-on", add an empty "Window" menu bar, and reorder them to "File", "View", "One", "Mesh", "Add-on", and "Window".

No change is made to the menus under the menu bar.
@yungyuc yungyuc self-assigned this Jun 8, 2024
@yungyuc yungyuc removed the mesh Spatial mesh label Jun 8, 2024
@yungyuc yungyuc mentioned this issue Jun 8, 2024
Merged
@yungyuc
Copy link
Member Author

yungyuc commented Jun 8, 2024

@yungyuc is reordering the menu bars in PR #356.

@yungyuc
Copy link
Member Author

yungyuc commented Jun 8, 2024

#356 finished reordering the menu bar. #357 is created to implement sub-window management under the "Window" menu.

@yungyuc yungyuc linked a pull request Jun 8, 2024 that will close this issue
Reorder menu bar #356
Merged
yungyuc added a commit to yungyuc/modmesh that referenced this issue Jun 9, 2024
@yungyuc
Move the items under the mesh menu outside the app
6eadbaf 
Following the description in solvcon#324. Move the code for the NACA airfoil and 3D mixed-element simple mesh to a new package `modmesh.gui`, outside the `modmesh.app` package.

Also add a new `modmesh::RPythonAction` for directly running Python function from Qt GUI.  The new Qt class is made for reorganizing the two mesh menu items.
yungyuc added a commit to yungyuc/modmesh that referenced this issue Jun 9, 2024
@yungyuc
Move the items under the mesh menu outside the app
b203324 
Following the description in solvcon#324. Move the code for the NACA airfoil and 3D mixed-element simple mesh to a new package `modmesh.gui`, outside the `modmesh.app` package.

Also add a new `modmesh::RPythonAction` for directly running Python function from Qt GUI.  The new Qt class is made for reorganizing the two mesh menu items.
@yungyuc yungyuc added the enhancement New feature or request label Jun 9, 2024
@yungyuc yungyuc mentioned this issue Jun 9, 2024
Merged
@yungyuc
Copy link
Member Author

yungyuc commented Jun 9, 2024

@yungyuc is reorganizing the mesh menu items using PR #360

@yungyuc yungyuc linked a pull request Jun 9, 2024 that will close this issue
Add items under "mesh" menu #360
Merged
@yungyuc yungyuc removed a link to a pull request Jun 9, 2024
Add items under "mesh" menu #360
Merged
@yungyuc yungyuc linked a pull request Jun 9, 2024 that will close this issue
Add items under "mesh" menu #360
Merged
@yungyuc
Copy link
Member Author

yungyuc commented Jun 28, 2024

Improvement of the windows menu will be tracked with issue #357. Improvement of the addon (app) menu will be tracked with issue #354. Work associated with this issue is all done.

@yungyuc yungyuc closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yungyuc yungyuc

Labels
enhancement New feature or request viewer Visualize stuff
Projects
viewer and GUI revamping
Status: Done
Milestone
GUI with first-class feature menus
Development

Successfully merging a pull request may close this issue.

Reorder menu bar yungyuc/modmesh
Add items under "mesh" menu yungyuc/modmesh
1 participant
@yungyuc