From 44cabd34631ed6137e557ba05da43e18d6174afa Mon Sep 17 00:00:00 2001 From: Ederson de Souza Date: Thu, 13 Aug 2015 10:33:35 -0300 Subject: [PATCH] string-icu: Memory issues Possible double free on string_change_case(); Memory leak on string_concat() and string_change_case(). Signed-off-by: Ederson de Souza --- src/modules/flow/string/string-icu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/flow/string/string-icu.c b/src/modules/flow/string/string-icu.c index ab42eddb4..1faed4b50 100644 --- a/src/modules/flow/string/string-icu.c +++ b/src/modules/flow/string/string-icu.c @@ -283,6 +283,7 @@ string_concat(struct sol_flow_node *node, fail_sz: free(dest); fail_to_utf8: + free(final); sol_flow_send_error_packet(node, -errno, u_errorName(err)); return -errno; } @@ -770,11 +771,12 @@ string_change_case(struct sol_flow_node *node, return r; -fail_to_utf8: fail_case_func: free(u_lower); +fail_to_utf8: fail_from_utf8: free(u_orig); + free(final); sol_flow_send_error_packet(node, -errno, u_errorName(err)); return -errno; }