Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Selectable aspect ratio #918

Open
mamalala opened this issue Aug 23, 2024 · 3 comments
Open

[FEATURE REQUEST] Selectable aspect ratio #918

mamalala opened this issue Aug 23, 2024 · 3 comments
Assignees
Labels
delayed Need to wait for something else to workout on this enhancement New feature or request

Comments

@mamalala
Copy link

Is your feature request related to a problem?

Currently the layer view maps the pixels in the layer to the pixels on screen 1:1.
This is just fine if the printer's pixels are square (like the Creality LD006, which is used until recently). However, for printers with non-square pixels, for example the Creality Halot Mage S (which is what i use now), the actual view is distorted. That is, for example, a circle in the model becomes an ellipse.

It would be a nice option if there is a checkbox in the/around the layer view that lets you select either a 1:1 pixel mapping (useful for the pixel editor) or to have a aspect-reatio correct layer view. Of course this depends on wether the loaded file contains the needed information, like the .cxdlpv4 format. It contains the print bed size in mm, as well as the pixel resolution per axis. If the file format does not contain such information, it could be configurable parameters.

It seems that with printers using a 14k resolution that they all do not have square pixels.

Describe the solution you'd like

Have a checkbox in the main window that toggles between a view with 1:1 pixel mapping and a view that takes the aspect ratio of the printer's pixel size into account.

If the loaded file contains the required information (print bed size X and Y in mm, and the screen resolution in X and Y), that should be used as default.

If the file format does not contain such information, these parameters should be configurable.

Files

No response

@mamalala mamalala added the enhancement New feature or request label Aug 23, 2024
Copy link

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

@sn4k3 sn4k3 added the delayed Need to wait for something else to workout on this label Aug 23, 2024
@sn4k3
Copy link
Owner

sn4k3 commented Aug 23, 2024

Also debated here:

Most likely won't be implemented. The huge impact, code modifications and translations to make this work is just too big for just a visual aids, UVtools is already slow with resolutions going up, adding something like this will make it worse.
The simple approach is resize to compensate the ratio but that would only enable a view-only of current layer as the modifications must be done on the original bitmap, as so tools could run, but not the pixel editor nor ROI or the mask selection tool. Resize and resize back to "original" state is also no viable option as some pixels would be lost in the conversion due the fractions, invalidating the original model.
I will have a look into the render but I suspect none of this is possible without major modifications and the read-only preview is the best I could do for now.

If anyone have an ideia or a working concept I'm open to it.

@mamalala
Copy link
Author

Hello,

understood. And i agree that this is purely a visual/display thing, and as such has a very low, if any, priority. Unfortunately i have no clue about C#, i only do C and C++, otherwise i could possibly contribute myself.

Thanks for your reply anyways, and for thinking about it. As such, you can then close the request if you want.

Greetings,

Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delayed Need to wait for something else to workout on this enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants