Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute image url for open graph image meta tag #112

Open
donni106 opened this issue Nov 23, 2017 · 0 comments
Open

Use absolute image url for open graph image meta tag #112

donni106 opened this issue Nov 23, 2017 · 0 comments

Comments

@donni106
Copy link
Member

Description

The og:image meta tag should have an absolute url to an image as value.
Currently Golden Cobra renders a relative url programmatically.

Steps to reproduce

The current rendering result for the og:image meta tag is:
<meta property="og:image" content="/system/images/ID/FORMAT/FILE">

Affected code lines if helpful

In this lines the first image of an article is used, if no manual url is given:
https://github.com/ikuseiGmbH/Goldencobra/blob/17fdf33f5e94277fed998acc185ff7e4d4871f26/app/models/goldencobra/article_concerns/meta_tag.rb#L39-L44

Expected results

The rendering result for the og:image meta tag should be:
<meta property="og:image" content="http(s)://WEBSITE/system/images/ID/FORMAT/FILE">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants