Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate_objects is not longer an array. #42

Open
LiamKearn opened this issue Feb 21, 2022 · 6 comments · May be fixed by #44
Open

truncate_objects is not longer an array. #42

LiamKearn opened this issue Feb 21, 2022 · 6 comments · May be fixed by #44

Comments

@LiamKearn
Copy link

truncate_objects is no longer an array and seems to be causing issue for us.

I think this is related to the removal of the default in #32 .

@LiamKearn
Copy link
Author

LiamKearn commented Feb 21, 2022

EG. https://github.com/silverstripe/silverstripe-populate/pull/32/files#diff-93dc79eb6bab3a17b4ea782351fd413f3b01e654949378c6b8dd974acdbc26ecR81 Foreach expects to iterate but doesn't get an iterable. Probably because it was removed here: https://github.com/silverstripe/silverstripe-populate/pull/32/files#diff-93dc79eb6bab3a17b4ea782351fd413f3b01e654949378c6b8dd974acdbc26ecL38.

Not sure what config returns if the config option is never set but It might be the cause.

@davejtoews
Copy link

It's not an array because it's undefined unless you set a value in your app.yml. Ran into the same issue myself. If you don't want to truncate anything you can set an empty array in app.yml to prevent the error.

DNADesign\Populate\Populate:
  truncate_objects: []

@LiamKearn
Copy link
Author

Thanks @davejtoews, should have moved to fix this when I discovered it!

This will make our CI a little cleaner if when we update next :)

@DanielTate
Copy link

This should be in the readme.

@DanielTate
Copy link

Is there a way to truncate only the objects created using the module?

@michalkleiner
Copy link
Contributor

Is there a way to truncate only the objects created using the module?

No. There's no record or a way of knowing which objects were created by this module and which existed before or after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants