From d064b8c6b963c4e3ce06f4c923833ac5123f902b Mon Sep 17 00:00:00 2001 From: Sabina Talipova Date: Fri, 13 Oct 2023 13:21:41 +1300 Subject: [PATCH] MNT Remove TODO comments --- src/Auth/Handler.php | 5 +---- src/Middleware/QueryCachingMiddleware.php | 2 -- src/Schema/DataObject/InterfaceBuilder.php | 2 -- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Auth/Handler.php b/src/Auth/Handler.php index 72fe1ca2..46f6442f 100644 --- a/src/Auth/Handler.php +++ b/src/Auth/Handler.php @@ -21,10 +21,7 @@ class Handler * @config * @var array * - * @internal Experimental config: - * @todo Move this to a per-schema configuration and refer to this schema from the current endpoint - * @link https://github.com/silverstripe/silverstripe-graphql/issues/58 - * @link https://github.com/silverstripe/silverstripe-graphql/issues/52 + * @internal Experimental config */ private static $authenticators = [ [ diff --git a/src/Middleware/QueryCachingMiddleware.php b/src/Middleware/QueryCachingMiddleware.php index 4d73a1ac..2df91664 100644 --- a/src/Middleware/QueryCachingMiddleware.php +++ b/src/Middleware/QueryCachingMiddleware.php @@ -111,8 +111,6 @@ protected function getCachedResponse(string $key): ?array // On cache success validate against cached classes foreach ($cached['classes'] as $class) { - // Note: Could combine these clases into a UNION to cut down on extravagant queries - // Todo: We can get last-deleted/modified as well for versioned records $lastEditedDate = DataObject::get($class)->max('LastEdited'); if (strtotime($lastEditedDate ?? '') > strtotime($cached['date'] ?? '')) { // class modified, fail validation of cache diff --git a/src/Schema/DataObject/InterfaceBuilder.php b/src/Schema/DataObject/InterfaceBuilder.php index aaa07634..42254957 100644 --- a/src/Schema/DataObject/InterfaceBuilder.php +++ b/src/Schema/DataObject/InterfaceBuilder.php @@ -65,8 +65,6 @@ public function createInterfaces(ModelType $modelType, array $interfaceStack = [ ) ->setTypeResolver([AbstractTypeResolver::class, 'resolveType']); - // TODO: this makes a really good case for - // https://github.com/silverstripe/silverstripe-graphql/issues/364 $validPlugins = []; foreach ($modelType->getPlugins() as $name => $config) { $plugin = $modelType->getPluginRegistry()->getPluginByID($name);