BrokenExternalLinksReport CSV Export displays Page.ID

[PsukheDelos]

Present on versions 1.0.7 & 1.0.10.

Steps to Replicate

• Add a link to a page (let's say the "Home" page) to a site that doesn't exist (clearly broken)
• Navigate to admin/reports/BrokenExternalLinksReport and run the BrokenExternalLinksReport
• You should see the title "Home" under the "Page link is on" column
• Export this gridfield using the "Export to CSV" button
• Open CSV, you will note "Page link is on" column has the Page ID (e.g. Update docs #2) instead of the Page Title (e.g. "Home").

[robbieaverill]

For some context in a discussion I had with @PsukheDelos via Slack - I don't think that the behaviour was deliberately opted in for, because it's not commented anywhere nor catered for in logic in this module.

If the column was a data column I would say it's better to leave it the way it is, but since it's a human-only column, and since you can't import this CSV via the same UI, I think it's fine to change it to display the same columns as what's in the CMS view.

We could even add both the human-only and page ID column for export.

[robbieaverill]

FYI, this doesn't happen in SS4

[raissanorth]

I can recreate this bug in SS4 using

silverstripe/externallinks                2.0.x-dev 3ff01bf
silverstripe/cms                          4.1.x-dev c6af885

Interestingly, the numbers don't appear to be correlated to the actual page ID's either. Compare the pages ...

... with the IDs from the exported CSV file.