Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hash link for intoto entries #59

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

bdehamer
Copy link
Contributor

Summary

The "hash" link on page for intoto entries is using the wrong hash value. Intoto entries contain two hash values:

  • hash is the digest of the entire DSSE envelope.
  • payloadHash is the digest of the payload contained within the DSSE envelope.

It appears that Rekor is only indexing the payloadHash value so it is not possible to look-up an entry by the envelope hash.

This fix updates the page to show the payload hash and updates the corresponding link to search the Rekor by this value.

image

Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer requested a review from a team as a code owner July 20, 2023 23:11
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer force-pushed the bdehamer/fix-intoto-hash-link branch from 80d1efc to a3d0762 Compare July 20, 2023 23:19
@bdehamer
Copy link
Contributor Author

The version of prettier used in GitHub Actions was no longer in sync with the version used in the "package.json" file resulting in formatting errors that were surfaced ONLY in CI. Adding a commit which fixes the formatting errors and updates the project version of prettier to v3.0.0

@bdehamer bdehamer merged commit af18da4 into main Jul 21, 2023
6 checks passed
@bdehamer bdehamer deleted the bdehamer/fix-intoto-hash-link branch July 21, 2023 13:18
kahboom pushed a commit to kahboom/rekor-search-ui that referenced this pull request Mar 8, 2024
kahboom pushed a commit to kahboom/rekor-search-ui that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants