Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow menu options to have text to the left of the selector #469

Open
2 tasks done
andrewtavis opened this issue Jun 21, 2024 · 1 comment
Open
2 tasks done

Allow menu options to have text to the left of the selector #469

andrewtavis opened this issue Jun 21, 2024 · 1 comment
Assignees
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jun 21, 2024

Terms

Description

As discussed in a recent call, we'd like to break #255 up into smaller issues :) This issue will focus on adding an option to put text to the left of selectors in menu options, so when there's a chevron as the right icon of a menu option, we could then put text like the current translation language to its left. We'll also use this in #255 for the menu options themselves. Designs for various menu options with this element can be seen here 🖼️

Contribution

@Jag-Marcel will be doing this as a part of GSoC 2024 ☀️ Please write in here so we can assign, and let us know if any support is needed! 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed -priority- High priority labels Jun 21, 2024
@Jag-Marcel
Copy link
Member

Thank you 🙏

Jag-Marcel added a commit to Jag-Marcel/Scribe-iOS that referenced this issue Jun 24, 2024
- Minor refactor to code for the button
- Reworked how the chevron is displayed on the button
- Added a label to the left of the chevron
- Resized elements of the button to be centred instead of slightly lower than the centre
- Added a button to language settings for picking a translation language
- Created temporary value to store currently selected translation language, the plan is for every keyboard to have one of these
Jag-Marcel added a commit to Jag-Marcel/Scribe-iOS that referenced this issue Jun 24, 2024
- Minor refactor to code for the button
- Reworked how the chevron is displayed on the button
- Added a label to the left of the chevron
- Resized elements of the button to be centred instead of slightly lower than the centre
- Added a button to language settings for picking a translation language
- Created temporary value to store currently selected translation language, the plan is for every keyboard to have one of these
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

2 participants