Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework buttons to use new configuration option #451

Open
2 tasks done
Jag-Marcel opened this issue Jun 1, 2024 · 0 comments
Open
2 tasks done

Rework buttons to use new configuration option #451

Jag-Marcel opened this issue Jun 1, 2024 · 0 comments
Labels
design Relates to UX/UI designs help wanted Extra attention is needed

Comments

@Jag-Marcel
Copy link
Member

Terms

Description

In #448 we discussed converting the buttons to use iOS 15's UIButton.Configuration feature. It automatically resizes text and images and has more settings for styling buttons.
This would mean that for example, instead of button.setTitle("title"), we would have a configuration for said button and use button.configuration.title = "title". This configuration can be re-used and doesn't have to be reset for every newly created button, so it would make sense to only create as many base configurations as needed and then add things like a title as needed.
So far, this is only used for missing conjugations, which you can find at the top of KeyboardStyling.swift, but it should ideally be used for as many custom buttons on the keyboard as is practical.

Contribution

I can assist with this if any help is needed, there is also this explanation on configurations to get started.

@Jag-Marcel Jag-Marcel added the design Relates to UX/UI designs label Jun 1, 2024
@andrewtavis andrewtavis added the help wanted Extra attention is needed label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Relates to UX/UI designs help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants