Upload e Download de ativos digitais grandes #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alteração em add_asset e update_asset Alteração em get_asset se o arquivo for grande: - a execução de add_asset e update_asset em duas etapas: primeiramente executando opac_ssm.upload_file que retorna o nome do arquivo grande e depois executando opac_ssm.add_asset incluindo asset.large_file_path. - a execução de get_asset também é em duas etapas: primeiramente executando opac_ssm.get_asset, depois executando opac_ssm.download_file, usando o arquivo identificado como asset.large_file_path. Relacionado com scieloorg/opac_ssm#390 tk185 Fixes scieloorg#185
patymori
reviewed
Oct 22, 2018
| try: | ||
| os.unlink(file_path) | ||
| except OSError: | ||
| logger.info('%s' % file_path) |
There was a problem hiding this comment.
Suggested change
| logger.info('%s' % file_path) | |
| logger.error('%s' % file_path) |
patymori
reviewed
Oct 22, 2018
| update_params['metadata'] = json.dumps({}) | ||
| elif not isinstance(metadata, dict): | ||
| metadata = metadata or {} | ||
| if not isinstance(metadata, dict): | ||
| error_msg = 'Param "metadata" must be a Dict or None.' |
There was a problem hiding this comment.
Suggested change
| error_msg = 'Param "metadata" must be a Dict or None.' | |
| error_msg = 'Param "metadata" must be a Dict.' |
patymori
reviewed
Oct 23, 2018
patymori
suggested changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alteração em add_asset e update_asset
Alteração em get_asset
se o arquivo for grande:
Relacionado com
scieloorg/opac_ssm#390
tk185
Fixes #185