-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adicionar a capacidade de pupolar o campo related_articles #302
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e825918
Adiciona uma nova propriedade para related_articles para obter os art…
gitnnolabs 6e44ca2
Adiciona uma nova função para obter o XML, capacida o fetch_data para…
gitnnolabs 7c00f6d
Verifica se é errata, adendo ou retratação e atualiza a respectiva re…
gitnnolabs 3eaceac
Adiciona a atualização do opac_schema
gitnnolabs 2a9692d
Remove comentário desnecessário
gitnnolabs 443a04a
Remove comentário desnecessário
gitnnolabs 644d401
Melhoras a descrição de como está sendo realizado os relacionamentos,…
gitnnolabs 7f63961
Retorna o conteúdo obtido na requisição
gitnnolabs e63ca9c
Remove comentário desnecessário
gitnnolabs 1fc2523
Melhoria na condicional
gitnnolabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitnnolabs Me parece que o PR está incompleto e incorreto
Pelo que entendo estamos resolvendo a situação:
documento A
documento B1
documento B2
No documento A, há no xml:
que são respectivamente dados de B1 e B2.
Este PR deve fazer o seguinte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertatakenaka não realizei a inclusão dos dados na errata que no exemplo seria o documento A, pois na interface do site, já contém a mensagem dessa relação.
Mas pensando melhor você tem razão, dessa forma mantemos na base de dados a relação de ida e volta:
['errata', 'retração', 'adendo'] <-> documento
Esse PR está contemplando somente:
documento -> ['errata', 'retração', 'adendo']
Agora com essa alteração, suspeito que removemos do packtools geração da caixa de errata quando existir a tag
related-articles
, correto?, para que o site fique responsável por montar a caixa tanto no documento que corrige(errata), quando no documento corrigido(artigo).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitnnolabs são dois ou 3 pontos diferentes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parece-me que tem razão.
Sim, entendi isso estava com o contexto do site