Rewrite compiler flag on new play project yields errors #17453
-
|
Creating a new Play application with g8 and the play-scala-seed.g8 template. sbt new playframework/play-scala-seed.g8 --branch 2.9.xI was testing the rewrite capabilities of the compiler with the following options: scalacOptions ++= Seq(
"-rewrite",
"-indent",
)Launching a sbt shell & compiling the project, I'm facing the following errors: Does anyone have ever faced this issue previously? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
Thanks for reporting @PeuTit, although following your reproduction steps I can't reproduce this. Is there any other details or steps that you can provide? |
Beta Was this translation helpful? Give feedback.
-
|
Actually, I was able to reproduce this. Interesting one. So what happens is that on the first compile it will take the Scala code that gets generated from the package views.html
import _root_.play.twirl.api.TwirlFeatureImports._
import _root_.play.twirl.api.TwirlHelperImports._
import _root_.play.twirl.api.Html
import _root_.play.twirl.api.JavaScript
import _root_.play.twirl.api.Txt
import _root_.play.twirl.api.Xml
import models._
import controllers._
import play.api.i18n._
import views.html._
import play.api.templates.PlayMagic._
import play.api.mvc._
import play.api.data._
object index extends _root_.play.twirl.api.BaseScalaTemplate[play.twirl.api.HtmlFormat.Appendable,_root_.play.twirl.api.Format[play.twirl.api.HtmlFormat.Appendable]](play.twirl.api.HtmlFormat) with _root_.play.twirl.api.Template0[play.twirl.api.HtmlFormat.Appendable] {
/**/
def apply/*1.2*/():play.twirl.api.HtmlFormat.Appendable = {
_display_ {
{
Seq[Any](format.raw/*2.1*/("""
"""),_display_(/*3.2*/main("Welcome to Play")/*3.25*/ {_display_(Seq[Any](format.raw/*3.27*/("""
"""),format.raw/*4.3*/("""<h1>Welcome to Play!</h1>
""")))}),format.raw/*5.2*/("""
"""))
}
}
}
def render(): play.twirl.api.HtmlFormat.Appendable = apply()
def f:(() => play.twirl.api.HtmlFormat.Appendable) = () => apply()
def ref: this.type = this
}
/*
-- GENERATED --
SOURCE: app/views/index.scala.html
HASH: f7d71d8a9f655317469a39627564796bcf2a545b
MATRIX: 722->1|818->4|845->6|876->29|915->31|944->34|1000->61
LINES: 21->1|26->2|27->3|27->3|27->3|28->4|29->5
-- GENERATED --
*/This then gets rewritten to package views.html
import _root_.play.twirl.api.TwirlFeatureImports._
import _root_.play.twirl.api.TwirlHelperImports._
import _root_.play.twirl.api.Html
import _root_.play.twirl.api.JavaScript
import _root_.play.twirl.api.Txt
import _root_.play.twirl.api.Xml
import models._
import controllers._
import play.api.i18n._
import views.html._
import play.api.templates.PlayMagic._
import play.api.mvc._
import play.api.data._
object index extends _root_.play.twirl.api.BaseScalaTemplate[play.twirl.api.HtmlFormat.Appendable,_root_.play.twirl.api.Format[play.twirl.api.HtmlFormat.Appendable]](play.twirl.api.HtmlFormat) with _root_.play.twirl.api.Template0[play.twirl.api.HtmlFormat.Appendable]:
/**/
def apply/*1.2*/():play.twirl.api.HtmlFormat.Appendable =
_display_:
Seq[Any](format.raw/*2.1*/("""
"""),_display_(/*3.2*/main("Welcome to Play")/*3.25*/ {_display_(Seq[Any](format.raw/*3.27*/("""
"""),format.raw/*4.3*/("""<h1>Welcome to Play!</h1>
""")))}),format.raw/*5.2*/("""
"""))
def render(): play.twirl.api.HtmlFormat.Appendable = apply()
def f:(() => play.twirl.api.HtmlFormat.Appendable) = () => apply()
def ref: this.type = this
/*
-- GENERATED --
SOURCE: app/views/index.scala.html
HASH: f7d71d8a9f655317469a39627564796bcf2a545b
MATRIX: 722->1|818->4|845->6|876->29|915->31|944->34|1000->61
LINES: 21->1|26->2|27->3|27->3|27->3|28->4|29->5
-- GENERATED --
*/ Which has a whole handful of problems. The thing is, is that I don't even think we should be trying to rewrite these files, but I don't know if there is a good way to filter them out since Dotty I believe is just going to try and rewrite everything, whether it's generated code or not. |
Beta Was this translation helpful? Give feedback.
-
|
I turned this into #17456, so I'll go ahead and close this. We can continue the discussion there. |
Beta Was this translation helpful? Give feedback.
I turned this into #17456, so I'll go ahead and close this. We can continue the discussion there.