Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add linter, get standardrb to pass again #171

Open
4 tasks
h-m-m opened this issue Jun 1, 2024 · 2 comments
Open
4 tasks

Re-add linter, get standardrb to pass again #171

h-m-m opened this issue Jun 1, 2024 · 2 comments
Assignees
@abachman

Comments

@h-m-m
Copy link
Collaborator

h-m-m commented Jun 1, 2024

Summary

We want to use a linter to help minimize surprises when submitting PRs and reviewing them

Things to Consider

@abachman started a PR, #168, that looks like what we want, but our branching/merging churn was very heavy at the time so he decided to postpone

His follow-up, #170, shows where in the pipeline you need to remove comments to enable linting again

Criteria for Completion

  • A linter that checks for standardrb compliance runs
  • The linter will flunk non-standard code
  • The linter adds a green check to PRs that pass the standard
  • The PR enabling the linter passes the standard
@abachman abachman self-assigned this Jun 1, 2024
@Naraveni
Copy link

Naraveni commented Jun 5, 2024

can I work on this

@h-m-m
Copy link
Collaborator Author

h-m-m commented Jun 5, 2024

@Naraveni Go for it! I look forward to seeing your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abachman abachman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abachman @h-m-m @Naraveni