From a965e043c72c4568206210d3e26ad099ae03c015 Mon Sep 17 00:00:00 2001
From: Tomasz Kalinowski <kalinowskit@gmail.com>
Date: Wed, 3 Jul 2024 11:44:18 -0400
Subject: [PATCH] Fix warning from `tfruns::training_run()` being unable to log
 optimizer learning rate.

---
 NEWS.md                  | 2 ++
 R/zzz-metrics-callback.R | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/NEWS.md b/NEWS.md
index a8feaad93..060a53d84 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -5,6 +5,8 @@
 
 - `keras_shape` objects (as returned by `keras3::shape()`) gain `==` and `!=` methods.
 
+- Fixed warning from `tfruns::training_run()` being unable to log optimizer learning rate.
+
 - Added compatibility with Keras v3.4.1 (no R user facing changes).
 
 User facing changes with upstream Keras v3.4.0:
diff --git a/R/zzz-metrics-callback.R b/R/zzz-metrics-callback.R
index 33069d705..f04bf7f62 100644
--- a/R/zzz-metrics-callback.R
+++ b/R/zzz-metrics-callback.R
@@ -119,7 +119,7 @@ callback_view_metrics <- Callback(
         optimizer <- model$optimizer
         if (!is.null(optimizer)) {
           model_info$optimizer <- py_str(optimizer)
-          model_info$learning_rate <- as.double(optimizer$lr)
+          model_info$learning_rate <- as.double(optimizer$learning_rate)
         }
         tfruns::write_run_metadata("properties", model_info)
       }, error = function(e) {