Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled offsets for compressed encodings #5

Closed
tovine opened this issue Mar 9, 2024 · 0 comments · Fixed by #6
Closed

Scaled offsets for compressed encodings #5

tovine opened this issue Mar 9, 2024 · 0 comments · Fixed by #6

Comments

@tovine
Copy link
Collaborator

tovine commented Mar 9, 2024

Hi,

First of all, I just noticed that you had taken over and started the proper fast-track process for this extension - thanks a lot!
I found one thing in the description for the compressed instructions:

In the case of the stack-pointer relative instructions we have

It computes its effective address by adding the zero-extended offset, scaled by 8

But not for the others.
Shouldn't it be the same there as well? I see the existing RV64 compressed encodings have the same scaling factor (by including immediate bits [7:3], and it would be beneficial to keep that here as well, for the increased immediate range (and avoiding the possibility for misaligned accesses, unless that's actually a desired feature).

Even if this was already the intended behavior, we should state it explicitly so there's no room for ambiguity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant