Add delete variable support (#20)

Adds the ability to remove an existing variable by name.

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Ability to detect HCL variables from a varfile. [#14]
 * Ability to delete workspaces. [#15]
+* Ability to delete variables. [#20]
 
 ### Fixed
 
@@ -32,3 +33,4 @@ Initial version with support for managing:
 [#15]: https://github.com/rgreinho/tfe-cli/pull/15
 [#18]: https://github.com/rgreinho/tfe-cli/pull/18
 [#19]: https://github.com/rgreinho/tfe-cli/pull/19
+[#20]: https://github.com/rgreinho/tfe-cli/pull/20

cmd/variable.go

@@ -102,16 +102,10 @@ var variableCreateCmd = &cobra.Command{
 			varOptions = append(varOptions, createVariableOptions(HCLVarFile, tfe.CategoryTerraform, true, false)...)
 		}
 
-		// List existing variables.
-		variables, err := listVariables(client, workspace.ID)
+		// List existing variables and index them by key.
+		indexedVars, err := indexVariables(client, workspace.ID, organization)
 		if err != nil {
-			log.Fatalf("Cannot list the variables for  %q: %s.", organization, err)
-		}
-
-		// Index them by key.
-		indexedVars := map[string]*tfe.Variable{}
-		for _, v := range variables {
-			indexedVars[v.Key] = v
+			log.Fatalf("Cannot index variables: %s.", err)
 		}
 
 		// Go through all the variables.
@@ -144,7 +138,7 @@ var variableCreateCmd = &cobra.Command{
 			if _, err = createVariable(client, workspace.ID, opts); err != nil {
 				log.Fatalf("Cannot create variable %q: %s.", *(opts.Key), err)
 			}
-			log.Debugf("Variable %q created successfully.", *(opts.Key))
+			log.Infof("Variable %q created successfully.", *(opts.Key))
 		}
 	},
 }
@@ -184,9 +178,53 @@ var variableListCmd = &cobra.Command{
 	},
 }
 
+var variableDeleteCmd = &cobra.Command{
+	Use:   "delete [WORKSPACE] [VARIABLE]",
+	Short: "Delete a TFE variable for a specific workspace",
+	Long:  `Delete a TFE variable for a specific workspace.`,
+	Args:  cobra.ExactArgs(2),
+	Run: func(cmd *cobra.Command, args []string) {
+		// Read the flags.
+		wsName := args[0]
+		varName := args[1]
+
+		// Setup the command.
+		organization, client, err := setup(cmd)
+		if err != nil {
+			log.Fatalf("Cannot execute the command: %s.", err)
+		}
+
+		// Retrieve the workspace.
+		workspace, err := readWorkspace(client, organization, wsName)
+		if err != nil {
+			log.Fatalf("Cannot retrieve workspace %q: %s.", wsName, err)
+		}
+
+		// List existing variables and index them by key.
+		indexedVars, err := indexVariables(client, workspace.ID, organization)
+		if err != nil {
+			log.Fatalf("Cannot index variables: %s.", err)
+		}
+
+		// Check if it exists.
+		v, exists := indexedVars[varName]
+		if !exists {
+			log.Warningf("Cannot delete variable %q: it does not exist.", varName)
+			return
+		}
+
+		// And delete it if it does.
+		if err := deleteVariable(client, workspace.ID, v.ID); err != nil {
+			log.Fatalf("Cannot delete variable %q: %s.", varName, err)
+		}
+		log.Infof("Variable %q deleted successfully.", varName)
+	},
+}
+
 func init() {
 	rootCmd.AddCommand(variableCmd)
 	variableCmd.AddCommand(variableCreateCmd)
+	variableCmd.AddCommand(variableDeleteCmd)
 	variableCmd.AddCommand(variableListCmd)
 
 	variableCreateCmd.Flags().StringArray("var", []string{}, "Create a regular variable")
@@ -257,3 +295,24 @@ func createVariableOptions(vars []string, category tfe.CategoryType, hcl, sensit
 	}
 	return optionList
 }
+
+func indexVariables(client *tfe.Client, workspaceID, organization string) (map[string]*tfe.Variable, error) {
+	// List existing variables.
+	variables, err := listVariables(client, workspaceID)
+	if err != nil {
+		return nil, fmt.Errorf("cannot list the variables for  %q: %s", organization, err)
+	}
+
+	// Index them by key.
+	indexedVars := map[string]*tfe.Variable{}
+	for _, v := range variables {
+		indexedVars[v.Key] = v
+	}
+
+	return indexedVars, nil
+}
+
+func deleteVariable(client *tfe.Client, workspaceID, variableID string) error {
+	return client.Variables.Delete(context.Background(), workspaceID, variableID)
+
+}