Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step_size not passed on to energym by integration #63

Open
rdnfn opened this issue Apr 11, 2022 · 0 comments
Open

step_size not passed on to energym by integration #63

rdnfn opened this issue Apr 11, 2022 · 0 comments
Labels
beobench_contrib If the code to resolve this issue will live in beobench_contrib repo, add this label. bug Something isn't working concerns: integrations
Milestone

Comments

@rdnfn
Copy link
Owner

rdnfn commented Apr 11, 2022

Problem

There appears to be a mismatch between the user-defined step size and the actual step size of the simulation. The plot below shows the solar radiation, and indicates that a day is about 480 steps (step_size 3min), as opposed to the 96 steps that the configured step_size of 15min would mean.

Screenshot 2022-04-11 at 17 37 15

Potential Solution

As far as I can tell the step_size parameter is not actually passed on to the Energym env making command, thus it defaults to another step_size. Creating the relevant logic should be sufficient to fix this.

@rdnfn rdnfn added bug Something isn't working concerns: integrations beobench_contrib If the code to resolve this issue will live in beobench_contrib repo, add this label. labels Apr 11, 2022
@rdnfn rdnfn modified the milestones: v0.4.3, v0.4.4 Apr 11, 2022
@rdnfn rdnfn modified the milestones: v0.4.4, v0.4.5 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beobench_contrib If the code to resolve this issue will live in beobench_contrib repo, add this label. bug Something isn't working concerns: integrations
Projects
None yet
Development

No branches or pull requests

1 participant