Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit token approval amount #1418

Open
lofieth opened this issue Mar 21, 2024 · 3 comments
Open

Add ability to edit token approval amount #1418

lofieth opened this issue Mar 21, 2024 · 3 comments

Comments

@lofieth
Copy link

lofieth commented Mar 21, 2024

To ensure safety, it's best to set the token approve amount to match the transaction amount by default.

Alternatively, we could incorporate a feature allowing users to adjust the token approve amount as needed.

See the example below:

Screenshot 2024-03-21 at 14 57 59
@lofieth lofieth changed the title Add ability to edit token approve amount Add ability to edit token approval amount Mar 21, 2024
@lofieth
Copy link
Author

lofieth commented Mar 21, 2024

I'm sure this will save a lot of wallets from being drained.

@Ncookiez
Copy link
Contributor

it's best to set the token approve amount to match the transaction amount by default

Absolutely. But the transaction request is made by the dapp you're interacting with, not your wallet. You should give them this feedback!

@lofieth
Copy link
Author

lofieth commented Mar 26, 2024

Then I guess it's better to add an edit button, so we don't just approve whatever amount the dapp is asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants