Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin mysqlclient to prevent dependency failures #1938

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mbordash2
Copy link
Contributor

Summary

GHA failing due to dependency needs of the mysqlclient.

Why This Is Needed

PyMySQL/mysqlclient#620

What Changed

Pinning mysql client to a version that doesn't have new dependencies required.

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@mbordash2 mbordash2 self-assigned this Jun 27, 2023
@github-actions github-actions bot added the maintenance General repo or CI/CD upkeep label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1938 (4c51628) into master (230ccf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1938   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         247      247           
  Lines       15667    15667           
=======================================
  Hits        14128    14128           
  Misses       1539     1539           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230ccf5...4c51628. Read the comment docs.

@mbordash2 mbordash2 merged commit 6f82f1f into master Jun 29, 2023
23 checks passed
@mbordash2 mbordash2 deleted the maintenance/mysqlclient-pin-gha-fix branch June 29, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General repo or CI/CD upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants