Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Adjustable alarm notification offsets #8

Open
ZacharyTalis opened this issue Aug 17, 2021 · 8 comments
Open

[Feature request] Adjustable alarm notification offsets #8

ZacharyTalis opened this issue Aug 17, 2021 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@ZacharyTalis
Copy link

Priority: Low, don't worry too hard about it

Background: deskclock/provider/AlarmInstance.java declares constants LOW_NOTIFICATION_HOUR_OFFSET and HIGH_NOTIFICATION_MINUTE_OFFSET. These values determine the "offset from alarm time to show" low and high priority notifications, respectively.

Request: Allow users to adjust these two values from the Settings page. I'd implement this feature myself if I had the coding chops :(

Your fork is excellent btw, thanks for making it <3

@qw123wh qw123wh added the help wanted Extra attention is needed label Aug 17, 2021
@qw123wh
Copy link
Owner

qw123wh commented Aug 17, 2021

if i could i would, i'm not a developer, i created a fork already done, and i added some commits (power off alarm) by copying and pasting from lineageos clock aosp (it's pretty much the same). I hope someday someone will create another fork and update it

@ZacharyTalis
Copy link
Author

gotchaaa, thanks for the heads-up
my partner might tackle this feature request someday, we'll see

@eml-lopez
Copy link

Hello!

I have tested your alarm application and it works perfectly with the Evolution X ROM (Android 10) on a Leeco C106 phone, with Snapdragon 652. However with another phone I have Realme X (RMX1901), with Snapdragon 710, with PixelPlusUI ROM ( Android 11), the application does not work.

Take this opportunity to congratulate you on your great work, because it seems to me a very useful application, since no custom ROM offers the possibility of setting an alarm that works with the phone turned off.

@qw123wh
Copy link
Owner

qw123wh commented Nov 10, 2021

@eml-lopez maybe it's a custom rom problem

@qw123wh
Copy link
Owner

qw123wh commented Nov 21, 2021

@ZacharyTalis @eml-lopez switch to the new updated app https://github.com/qw123wh/new-clock/releases/tag/1.0

@ZacharyTalis
Copy link
Author

Thank you!! <3

I see you're porting these old issues to the new repo. Once you do that here, you can close this older issue.

@eml-lopez
Copy link

Okay. Thanks!

I have tried your new app, but it still does not work on Android 11 with Snapdragon 710

@qw123wh
Copy link
Owner

qw123wh commented Nov 21, 2021

@eml-lopez open a new issue on the new app, then we will continue there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants