Skip to content

Latest commit

 

History

History
164 lines (115 loc) · 6.15 KB

CONTRIBUTOR.md

File metadata and controls

164 lines (115 loc) · 6.15 KB
Raw

Contributing to Qrimatic

We'd love for you to contribute to our source code and to make Qrimatic even better.

Here are the guidelines we'd like you to follow:

Code of Conduct

Help us keep Qrimatic open and inclusive. Please read and follow our Code of Conduct.

Questions, Bugs, Features

Found an Issue or Bug?

If you find a bug or are having a problem using Qrimatic, help us by submitting an issue to our GitHub Repository. Even better, you can submit a Pull Request with a fix.

Please see the Submission Guidelines below.

Missing a Feature?

You can request a new feature by submitting an issue to our GitHub Repository.

If you would like to implement a new feature then consider what kind of change it is:

Issue Submission Guidelines

Before you submit your issue search the archive, maybe your question was already answered.

If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues.

Please use this form when filing a new issue:

  • Overview of the Issue - if an error is being thrown a non-minified stack trace helps
  • Motivation for or Use Case - explain why this is a bug for you
  • Qri Version(s) - is it a regression?
  • Operating System - is this a problem with all browsers or only specific ones?
  • Reproduce the Error - please provide an unambiguous set of steps we can use to reproduce the error.
  • Related Issues - has a similar issue been reported before?
  • Suggest a Fix - if you can't fix the bug yourself, perhaps you can point to what might be causing the problem (line of code or commit)

Pull Request Submission Guidelines

Before you submit your pull request consider the following guidelines:

  • Search GitHub for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.

  • Create the [development environment][developers.setup]

  • Make your changes in a new git branch:

    git checkout -b my-fix-branch master

  • Create your patch commit.

  • Follow our Coding Rules.

  • Commit your changes using a descriptive commit message that follows our commit message conventions. Adherence to the commit message conventions is required, because release notes are automatically generated from these messages.

    git commit -a

    Note: the optional commit -a command line option will automatically "add" and "rm" edited files.

  • Push your branch to GitHub:

    git push origin my-fix-branch

  • In GitHub, send a pull request to qrimatic:master. This will trigger the check of the Contributor License Agreement.

  • If we suggest changes, then:

    • Make the required updates.

    • Re-run the Qri test suite to ensure tests are still passing.

    • Commit your changes to your branch (e.g. my-fix-branch).

    • Push the changes to your GitHub repository (this will update your Pull Request).

      You can also amend the initial commits and force push them to the branch.

      git rebase master -i
git push origin my-fix-branch -f

      This is generally easier to follow, but seperate commits are useful if the Pull Request contains iterations that might be interesting to see side-by-side.

That's it! Thank you for your contribution!

After your pull request is merged

After your pull request is merged, you can safely delete your branch and pull the changes from the main (upstream) repository:

  • Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:

    git push origin --delete my-fix-branch

  • Check out the master branch:

    git checkout master -f

  • Delete the local branch:

    git branch -D my-fix-branch

  • Update your master with the latest upstream version:

    git pull --ff upstream master

Signing the Contributor License Agreement (CLA)

Upon submmitting a Pull Request, a friendly bot will ask you to sign our CLA if you haven't done so before. Unfortunately, this is necessary for documentation changes, too. It's a quick process, we promise!

This documentation has been adapted from the Data Together, Hyper, and AngularJS documentation.