Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Story: California State Parks Data #6

Open
4 of 5 tasks
feep opened this issue Mar 30, 2020 · 5 comments
Open
4 of 5 tasks

Data Story: California State Parks Data #6

feep opened this issue Mar 30, 2020 · 5 comments

Comments

@feep
Copy link
Contributor

feep commented Mar 30, 2020

Three stories:

Generate and use dataset

Improve dataset

  • meta.json
  • transform.star to do what the python script did in the first story

Validate with schema.json

  • structure.json
@feep
Copy link
Contributor Author

feep commented Apr 2, 2020

@feep
Copy link
Contributor Author

feep commented Apr 2, 2020

We can cut the validation bit, and I can publish the dataset to a new user if you want the story to go asap.

@feep
Copy link
Contributor Author

feep commented Apr 22, 2020

structure.json bit deferred to a separate story, so we can post this.

Especially since @Arqu is working on jsonschema.

qri-io/jsonschema#63 and future PRs.

@Arqu
Copy link

Arqu commented Apr 22, 2020

Oh, just to add to this, think you should definitely proceed with this and "unblock" yourself for the time being by doing what Holger did and you can refer to this for a bit more input.

In a nutshell, for the problematic onces you should do an anyOf with your current validation rules + type [string, null] to account for the None/Null values. A bit of fiddling should get you to a spot that works. It's not pretty, but should get you over the hump. The jsonschema work will take a while to land, especially the part with nullables.

@feep
Copy link
Contributor Author

feep commented Apr 22, 2020

Right, I got the working JSON from Holger.

=]

Thanks, Holger.

Anyway still deferring structure.json for other reasons.

Will write later. Maybe with new "AllowNullable" Maybe without.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants