Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecations] Deprecate in view of v0.6 release #2446

Open
wants to merge 2 commits into
base: gh/vmoens/26/base
Choose a base branch
from
Open

[Deprecations] Deprecate in view of v0.6 release #2446

wants to merge 2 commits into from

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 20, 2024 •
edited
Loading

@vmoens
Update
fac26d1 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2446

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 10 Unrelated Failures

As of commit 66af071 with merge base e294c68 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Sep 20, 2024
@vmoens
[Deprecations] Deprecate in view of v0.6 release
81fce90 
ghstack-source-id: 44add0a6a9130e23598eba798d175e946727acca
Pull Request resolved: #2446
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 146. Improved: $\large\color{#35bf28}57$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 62.8297ms 62.2062ms 16.0756 Ops/s 16.2832 Ops/s $\color{#d91a1a}-1.27\%$
test_sync 44.8982ms 34.3285ms 29.1303 Ops/s 28.0558 Ops/s $\color{#35bf28}+3.83\%$
test_async 0.1662s 33.3655ms 29.9711 Ops/s 30.5155 Ops/s $\color{#d91a1a}-1.78\%$
test_simple 0.5298s 0.4377s 2.2845 Ops/s 2.4123 Ops/s $\textbf{\color{#d91a1a}-5.30\%}$
test_transformed 0.6921s 0.6051s 1.6525 Ops/s 1.7079 Ops/s $\color{#d91a1a}-3.24\%$
test_serial 1.3917s 1.3248s 0.7548 Ops/s 0.7637 Ops/s $\color{#d91a1a}-1.16\%$
test_parallel 1.3166s 1.2268s 0.8151 Ops/s 0.8383 Ops/s $\color{#d91a1a}-2.77\%$
test_step_mdp_speed[True-True-True-True-True] 0.1947ms 27.2475μs 36.7006 KOps/s 36.3677 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[True-True-True-True-False] 65.5540μs 16.0100μs 62.4610 KOps/s 62.0411 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-True-True-False-True] 54.5920μs 15.8101μs 63.2509 KOps/s 63.2402 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[True-True-True-False-False] 50.1240μs 9.2887μs 107.6577 KOps/s 106.9243 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[True-True-False-True-True] 76.9540μs 29.2581μs 34.1786 KOps/s 33.8606 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[True-True-False-True-False] 69.1700μs 17.9189μs 55.8071 KOps/s 55.9385 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-True-False-False-True] 75.9420μs 17.4872μs 57.1845 KOps/s 57.3637 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[True-True-False-False-False] 53.4400μs 10.9323μs 91.4719 KOps/s 90.9209 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[True-False-True-True-True] 0.1042ms 31.0125μs 32.2451 KOps/s 32.1724 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-False-True-True-False] 75.2820μs 19.4374μs 51.4472 KOps/s 51.3356 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-False-True-False-True] 62.3970μs 17.3858μs 57.5182 KOps/s 57.5497 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[True-False-True-False-False] 39.0430μs 10.9944μs 90.9553 KOps/s 91.3451 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-False-False-True-True] 93.0240μs 32.4743μs 30.7936 KOps/s 30.8434 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-False-False-True-False] 74.9710μs 21.0228μs 47.5674 KOps/s 47.4340 KOps/s $\color{#35bf28}+0.28\%$
test_step_mdp_speed[True-False-False-False-True] 66.9560μs 18.8980μs 52.9158 KOps/s 53.1948 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[True-False-False-False-False] 66.4750μs 12.4433μs 80.3648 KOps/s 79.8472 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[False-True-True-True-True] 79.0480μs 31.0009μs 32.2572 KOps/s 32.0087 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[False-True-True-True-False] 0.1146ms 19.1687μs 52.1683 KOps/s 50.8406 KOps/s $\color{#35bf28}+2.61\%$
test_step_mdp_speed[False-True-True-False-True] 72.4960μs 19.8156μs 50.4654 KOps/s 50.1771 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[False-True-True-False-False] 64.2810μs 12.1091μs 82.5824 KOps/s 82.1092 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-False-True-True] 87.1740μs 32.4385μs 30.8276 KOps/s 30.6683 KOps/s $\color{#35bf28}+0.52\%$
test_step_mdp_speed[False-True-False-True-False] 68.4590μs 21.0244μs 47.5638 KOps/s 47.2227 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-True-False-False-True] 3.0083ms 21.4065μs 46.7148 KOps/s 46.7007 KOps/s $\color{#35bf28}+0.03\%$
test_step_mdp_speed[False-True-False-False-False] 64.5910μs 13.6340μs 73.3463 KOps/s 73.1087 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[False-False-True-True-True] 93.6960μs 33.9533μs 29.4522 KOps/s 29.3484 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[False-False-True-True-False] 57.7990μs 22.5912μs 44.2650 KOps/s 43.8344 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[False-False-True-False-True] 90.0190μs 21.3137μs 46.9181 KOps/s 47.0214 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-False-True-False-False] 49.5130μs 13.7388μs 72.7866 KOps/s 72.7387 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[False-False-False-True-True] 97.5130μs 35.4680μs 28.1944 KOps/s 28.2896 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[False-False-False-True-False] 63.9000μs 24.2732μs 41.1976 KOps/s 41.4559 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[False-False-False-False-True] 79.9790μs 22.5424μs 44.3609 KOps/s 44.1360 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[False-False-False-False-False] 58.7500μs 14.9574μs 66.8564 KOps/s 65.7489 KOps/s $\color{#35bf28}+1.68\%$
test_values[generalized_advantage_estimate-True-True] 11.1450ms 9.7554ms 102.5070 Ops/s 103.7741 Ops/s $\color{#d91a1a}-1.22\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.1837ms 33.8122ms 29.5751 Ops/s 27.8509 Ops/s $\textbf{\color{#35bf28}+6.19\%}$
test_values[td0_return_estimate-False-False] 0.2812ms 0.2122ms 4.7116 KOps/s 5.2045 KOps/s $\textbf{\color{#d91a1a}-9.47\%}$
test_values[td1_return_estimate-False-False] 26.7996ms 24.4234ms 40.9444 Ops/s 41.9919 Ops/s $\color{#d91a1a}-2.49\%$
test_values[vec_td1_return_estimate-False-False] 36.0891ms 33.9256ms 29.4762 Ops/s 27.8129 Ops/s $\textbf{\color{#35bf28}+5.98\%}$
test_values[td_lambda_return_estimate-True-False] 36.9203ms 35.0255ms 28.5506 Ops/s 28.8273 Ops/s $\color{#d91a1a}-0.96\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.3596ms 33.9589ms 29.4474 Ops/s 27.4603 Ops/s $\textbf{\color{#35bf28}+7.24\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.5904ms 8.3015ms 120.4600 Ops/s 123.7176 Ops/s $\color{#d91a1a}-2.63\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4299ms 2.0438ms 489.2731 Ops/s 490.0469 Ops/s $\color{#d91a1a}-0.16\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6126ms 0.3643ms 2.7448 KOps/s 2.7896 KOps/s $\color{#d91a1a}-1.61\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 49.1742ms 46.0849ms 21.6991 Ops/s 20.6528 Ops/s $\textbf{\color{#35bf28}+5.07\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.1600ms 3.2856ms 304.3603 Ops/s 319.4877 Ops/s $\color{#d91a1a}-4.73\%$
test_dqn_speed[False-None] 6.9481ms 1.3783ms 725.5203 Ops/s 754.4905 Ops/s $\color{#d91a1a}-3.84\%$
test_dqn_speed[False-backward] 2.0337ms 1.8781ms 532.4625 Ops/s 539.6396 Ops/s $\color{#d91a1a}-1.33\%$
test_dqn_speed[True-None] 0.8043ms 0.4915ms 2.0345 KOps/s 2.0977 KOps/s $\color{#d91a1a}-3.01\%$
test_dqn_speed[True-backward] 0.9725ms 0.9052ms 1.1047 KOps/s 1.0786 KOps/s $\color{#35bf28}+2.42\%$
test_dqn_speed[reduce-overhead-None] 0.7189ms 0.4727ms 2.1154 KOps/s 1.9811 KOps/s $\textbf{\color{#35bf28}+6.78\%}$
test_dqn_speed[reduce-overhead-backward] 0.9438ms 0.8931ms 1.1196 KOps/s 1.1158 KOps/s $\color{#35bf28}+0.35\%$
test_ddpg_speed[False-None] 5.4255ms 2.8754ms 347.7720 Ops/s 351.0204 Ops/s $\color{#d91a1a}-0.93\%$
test_ddpg_speed[False-backward] 4.2989ms 4.0251ms 248.4404 Ops/s 245.7871 Ops/s $\color{#35bf28}+1.08\%$
test_ddpg_speed[True-None] 1.3079ms 1.0406ms 960.9737 Ops/s 944.1623 Ops/s $\color{#35bf28}+1.78\%$
test_ddpg_speed[True-backward] 2.1963ms 2.0018ms 499.5545 Ops/s 479.8015 Ops/s $\color{#35bf28}+4.12\%$
test_ddpg_speed[reduce-overhead-None] 1.4833ms 1.0380ms 963.4346 Ops/s 932.1459 Ops/s $\color{#35bf28}+3.36\%$
test_ddpg_speed[reduce-overhead-backward] 2.1575ms 1.9775ms 505.6823 Ops/s 489.0382 Ops/s $\color{#35bf28}+3.40\%$
test_sac_speed[False-None] 9.5008ms 8.4507ms 118.3330 Ops/s 86.7664 Ops/s $\textbf{\color{#35bf28}+36.38\%}$
test_sac_speed[False-backward] 13.2681ms 11.4509ms 87.3294 Ops/s 86.6324 Ops/s $\color{#35bf28}+0.80\%$
test_sac_speed[True-None] 4.8624ms 2.1005ms 476.0722 Ops/s 476.9738 Ops/s $\color{#d91a1a}-0.19\%$
test_sac_speed[True-backward] 4.3659ms 3.9232ms 254.8944 Ops/s 231.4101 Ops/s $\textbf{\color{#35bf28}+10.15\%}$
test_sac_speed[reduce-overhead-None] 2.5705ms 2.1339ms 468.6192 Ops/s 423.5934 Ops/s $\textbf{\color{#35bf28}+10.63\%}$
test_sac_speed[reduce-overhead-backward] 4.5348ms 4.0697ms 245.7194 Ops/s 243.0067 Ops/s $\color{#35bf28}+1.12\%$
test_redq_speed[False-None] 15.1865ms 13.5017ms 74.0647 Ops/s 70.8305 Ops/s $\color{#35bf28}+4.57\%$
test_redq_speed[False-backward] 24.2735ms 23.4134ms 42.7106 Ops/s 42.5413 Ops/s $\color{#35bf28}+0.40\%$
test_redq_speed[True-None] 6.3676ms 5.8056ms 172.2486 Ops/s 167.3437 Ops/s $\color{#35bf28}+2.93\%$
test_redq_speed[True-backward] 14.0582ms 13.2365ms 75.5488 Ops/s 73.2085 Ops/s $\color{#35bf28}+3.20\%$
test_redq_speed[reduce-overhead-None] 6.1697ms 5.6704ms 176.3556 Ops/s 165.9188 Ops/s $\textbf{\color{#35bf28}+6.29\%}$
test_redq_speed[reduce-overhead-backward] 17.0976ms 13.5080ms 74.0299 Ops/s 74.1222 Ops/s $\color{#d91a1a}-0.12\%$
test_redq_deprec_speed[False-None] 16.1989ms 14.3886ms 69.4997 Ops/s 69.2365 Ops/s $\color{#35bf28}+0.38\%$
test_redq_deprec_speed[False-backward] 21.4394ms 20.2930ms 49.2780 Ops/s 49.5054 Ops/s $\color{#d91a1a}-0.46\%$
test_redq_deprec_speed[True-None] 5.0109ms 4.5900ms 217.8629 Ops/s 223.9170 Ops/s $\color{#d91a1a}-2.70\%$
test_redq_deprec_speed[True-backward] 9.8483ms 9.4363ms 105.9737 Ops/s 107.1725 Ops/s $\color{#d91a1a}-1.12\%$
test_redq_deprec_speed[reduce-overhead-None] 5.0417ms 4.2395ms 235.8781 Ops/s 213.9143 Ops/s $\textbf{\color{#35bf28}+10.27\%}$
test_redq_deprec_speed[reduce-overhead-backward] 9.2432ms 8.9599ms 111.6084 Ops/s 107.5565 Ops/s $\color{#35bf28}+3.77\%$
test_td3_speed[False-None] 12.2742ms 8.4980ms 117.6750 Ops/s 114.1001 Ops/s $\color{#35bf28}+3.13\%$
test_td3_speed[False-backward] 11.2163ms 10.8247ms 92.3811 Ops/s 84.9064 Ops/s $\textbf{\color{#35bf28}+8.80\%}$
test_td3_speed[True-None] 3.0517ms 2.1607ms 462.8135 Ops/s 428.3822 Ops/s $\textbf{\color{#35bf28}+8.04\%}$
test_td3_speed[True-backward] 3.9003ms 3.5634ms 280.6292 Ops/s 229.0487 Ops/s $\textbf{\color{#35bf28}+22.52\%}$
test_td3_speed[reduce-overhead-None] 2.1539ms 1.9384ms 515.8906 Ops/s 419.5268 Ops/s $\textbf{\color{#35bf28}+22.97\%}$
test_td3_speed[reduce-overhead-backward] 3.5874ms 3.4939ms 286.2110 Ops/s 236.2512 Ops/s $\textbf{\color{#35bf28}+21.15\%}$
test_cql_speed[False-None] 40.3806ms 35.4847ms 28.1812 Ops/s 26.1337 Ops/s $\textbf{\color{#35bf28}+7.83\%}$
test_cql_speed[False-backward] 49.9221ms 46.1107ms 21.6869 Ops/s 20.1486 Ops/s $\textbf{\color{#35bf28}+7.64\%}$
test_cql_speed[True-None] 26.9077ms 16.4949ms 60.6246 Ops/s 59.1653 Ops/s $\color{#35bf28}+2.47\%$
test_cql_speed[True-backward] 24.0863ms 22.7858ms 43.8869 Ops/s 41.6303 Ops/s $\textbf{\color{#35bf28}+5.42\%}$
test_cql_speed[reduce-overhead-None] 16.7637ms 15.9833ms 62.5655 Ops/s 59.9768 Ops/s $\color{#35bf28}+4.32\%$
test_cql_speed[reduce-overhead-backward] 23.9393ms 22.5403ms 44.3650 Ops/s 41.2202 Ops/s $\textbf{\color{#35bf28}+7.63\%}$
test_a2c_speed[False-None] 8.6029ms 7.1663ms 139.5412 Ops/s 125.7010 Ops/s $\textbf{\color{#35bf28}+11.01\%}$
test_a2c_speed[False-backward] 16.2293ms 14.3221ms 69.8221 Ops/s 64.5193 Ops/s $\textbf{\color{#35bf28}+8.22\%}$
test_a2c_speed[True-None] 3.6658ms 3.3256ms 300.6970 Ops/s 275.0129 Ops/s $\textbf{\color{#35bf28}+9.34\%}$
test_a2c_speed[True-backward] 10.4126ms 9.9287ms 100.7178 Ops/s 92.9512 Ops/s $\textbf{\color{#35bf28}+8.36\%}$
test_a2c_speed[reduce-overhead-None] 4.0243ms 3.3325ms 300.0765 Ops/s 283.1754 Ops/s $\textbf{\color{#35bf28}+5.97\%}$
test_a2c_speed[reduce-overhead-backward] 11.1955ms 10.0277ms 99.7236 Ops/s 90.6582 Ops/s $\textbf{\color{#35bf28}+10.00\%}$
test_ppo_speed[False-None] 8.9016ms 7.4673ms 133.9180 Ops/s 118.0287 Ops/s $\textbf{\color{#35bf28}+13.46\%}$
test_ppo_speed[False-backward] 16.3197ms 14.8838ms 67.1872 Ops/s 61.8512 Ops/s $\textbf{\color{#35bf28}+8.63\%}$
test_ppo_speed[True-None] 4.0568ms 3.7030ms 270.0526 Ops/s 244.8068 Ops/s $\textbf{\color{#35bf28}+10.31\%}$
test_ppo_speed[True-backward] 10.4400ms 9.9302ms 100.7030 Ops/s 94.5277 Ops/s $\textbf{\color{#35bf28}+6.53\%}$
test_ppo_speed[reduce-overhead-None] 4.2881ms 3.7281ms 268.2336 Ops/s 250.4746 Ops/s $\textbf{\color{#35bf28}+7.09\%}$
test_ppo_speed[reduce-overhead-backward] 10.7986ms 9.7580ms 102.4800 Ops/s 93.7211 Ops/s $\textbf{\color{#35bf28}+9.35\%}$
test_reinforce_speed[False-None] 7.8218ms 6.4364ms 155.3653 Ops/s 142.5703 Ops/s $\textbf{\color{#35bf28}+8.97\%}$
test_reinforce_speed[False-backward] 11.2227ms 9.7561ms 102.4996 Ops/s 94.7653 Ops/s $\textbf{\color{#35bf28}+8.16\%}$
test_reinforce_speed[True-None] 2.9693ms 2.6538ms 376.8185 Ops/s 330.2370 Ops/s $\textbf{\color{#35bf28}+14.11\%}$
test_reinforce_speed[True-backward] 9.1452ms 8.7094ms 114.8185 Ops/s 103.3315 Ops/s $\textbf{\color{#35bf28}+11.12\%}$
test_reinforce_speed[reduce-overhead-None] 3.3658ms 2.7282ms 366.5374 Ops/s 321.9954 Ops/s $\textbf{\color{#35bf28}+13.83\%}$
test_reinforce_speed[reduce-overhead-backward] 9.4886ms 8.6547ms 115.5436 Ops/s 106.4269 Ops/s $\textbf{\color{#35bf28}+8.57\%}$
test_iql_speed[False-None] 33.5188ms 32.3159ms 30.9445 Ops/s 29.4617 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_iql_speed[False-backward] 47.1132ms 45.0722ms 22.1866 Ops/s 21.0290 Ops/s $\textbf{\color{#35bf28}+5.51\%}$
test_iql_speed[True-None] 14.7304ms 13.7357ms 72.8028 Ops/s 68.9937 Ops/s $\textbf{\color{#35bf28}+5.52\%}$
test_iql_speed[True-backward] 25.7190ms 25.0098ms 39.9843 Ops/s 37.6796 Ops/s $\textbf{\color{#35bf28}+6.12\%}$
test_iql_speed[reduce-overhead-None] 14.5877ms 13.7324ms 72.8203 Ops/s 67.9227 Ops/s $\textbf{\color{#35bf28}+7.21\%}$
test_iql_speed[reduce-overhead-backward] 27.1732ms 25.0450ms 39.9281 Ops/s 37.8845 Ops/s $\textbf{\color{#35bf28}+5.39\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.8335ms 5.2965ms 188.8032 Ops/s 179.6091 Ops/s $\textbf{\color{#35bf28}+5.12\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0011ms 0.4904ms 2.0390 KOps/s 1.9477 KOps/s $\color{#35bf28}+4.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8026ms 0.4670ms 2.1414 KOps/s 2.1000 KOps/s $\color{#35bf28}+1.97\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.3944ms 5.1237ms 195.1729 Ops/s 182.0616 Ops/s $\textbf{\color{#35bf28}+7.20\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9268ms 0.4790ms 2.0876 KOps/s 1.9776 KOps/s $\textbf{\color{#35bf28}+5.57\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8202ms 0.4626ms 2.1618 KOps/s 2.0626 KOps/s $\color{#35bf28}+4.81\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.3585ms 1.6240ms 615.7817 Ops/s 605.6274 Ops/s $\color{#35bf28}+1.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.2876ms 1.5328ms 652.4176 Ops/s 635.8264 Ops/s $\color{#35bf28}+2.61\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.5450ms 5.3251ms 187.7896 Ops/s 172.1032 Ops/s $\textbf{\color{#35bf28}+9.11\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.4300ms 0.6360ms 1.5723 KOps/s 1.5119 KOps/s $\color{#35bf28}+3.99\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8105ms 0.5975ms 1.6737 KOps/s 1.5739 KOps/s $\textbf{\color{#35bf28}+6.35\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.8886ms 5.2493ms 190.5023 Ops/s 174.7769 Ops/s $\textbf{\color{#35bf28}+9.00\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2690ms 0.4923ms 2.0312 KOps/s 1.9474 KOps/s $\color{#35bf28}+4.31\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7290ms 0.4620ms 2.1645 KOps/s 1.9370 KOps/s $\textbf{\color{#35bf28}+11.75\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 8.4803ms 5.3285ms 187.6699 Ops/s 178.0200 Ops/s $\textbf{\color{#35bf28}+5.42\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 3.3775ms 0.4883ms 2.0480 KOps/s 2.0001 KOps/s $\color{#35bf28}+2.39\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7097ms 0.4642ms 2.1540 KOps/s 2.0221 KOps/s $\textbf{\color{#35bf28}+6.52\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.7716ms 5.4007ms 185.1600 Ops/s 170.3564 Ops/s $\textbf{\color{#35bf28}+8.69\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7702ms 0.6208ms 1.6109 KOps/s 1.5074 KOps/s $\textbf{\color{#35bf28}+6.87\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.5212ms 0.6101ms 1.6392 KOps/s 1.6003 KOps/s $\color{#35bf28}+2.43\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.4196s 12.6146ms 79.2730 Ops/s 196.5023 Ops/s $\textbf{\color{#d91a1a}-59.66\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.0389ms 13.3330ms 75.0019 Ops/s 70.2172 Ops/s $\textbf{\color{#35bf28}+6.81\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.1194ms 1.3943ms 717.1872 Ops/s 701.5111 Ops/s $\color{#35bf28}+2.23\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 5.6960ms 4.2764ms 233.8438 Ops/s 196.2046 Ops/s $\textbf{\color{#35bf28}+19.18\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.6576ms 13.3886ms 74.6904 Ops/s 72.2878 Ops/s $\color{#35bf28}+3.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.6188ms 1.4246ms 701.9725 Ops/s 716.4230 Ops/s $\color{#d91a1a}-2.02\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.3736s 11.8108ms 84.6680 Ops/s 207.9770 Ops/s $\textbf{\color{#d91a1a}-59.29\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.5155ms 13.4597ms 74.2960 Ops/s 71.3728 Ops/s $\color{#35bf28}+4.10\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.3235ms 1.5271ms 654.8509 Ops/s 597.4638 Ops/s $\textbf{\color{#35bf28}+9.61\%}$

@vmoens
Update
66af071 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Sep 20, 2024
@vmoens
[Deprecations] Deprecate in view of v0.6 release
f170e66 
ghstack-source-id: b2849c7549aa344cc9eab4a91a8da827c85f8876
Pull Request resolved: #2446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot