From 33e86c518d35aa898613aaad249f1f7f2d90f08f Mon Sep 17 00:00:00 2001 From: Vincent Moens Date: Mon, 23 Sep 2024 16:25:07 +0100 Subject: [PATCH] [CI] Fix windows build legacy ghstack-source-id: 5931159572a19a8c25ce774d050d2054cdbabae5 Pull Request resolved: https://github.com/pytorch/rl/pull/2450 --- .github/workflows/build-wheels-windows.yml | 2 +- .github/workflows/wheels-legacy.yml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-wheels-windows.yml b/.github/workflows/build-wheels-windows.yml index 1d47449568c..556d805c643 100644 --- a/.github/workflows/build-wheels-windows.yml +++ b/.github/workflows/build-wheels-windows.yml @@ -37,7 +37,7 @@ jobs: post-script: "python packaging/wheel/relocate.py" smoke-test-script: test/smoke_test.py package-name: torchrl - name: pytorch/rl + name: ${{ matrix.repository }} uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@main with: repository: ${{ matrix.repository }} diff --git a/.github/workflows/wheels-legacy.yml b/.github/workflows/wheels-legacy.yml index 25a42b80434..998b9eba4b2 100644 --- a/.github/workflows/wheels-legacy.yml +++ b/.github/workflows/wheels-legacy.yml @@ -19,7 +19,7 @@ jobs: runs-on: windows-latest strategy: matrix: - python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]] + python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]] steps: - name: Setup Python uses: actions/setup-python@v2 @@ -37,12 +37,12 @@ jobs: python3 -mpip install wheel TORCHRL_BUILD_VERSION=0.5.0 python3 setup.py bdist_wheel - name: Upload wheel for the test-wheel job - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: torchrl-win-${{ matrix.python_version[0] }}.whl path: dist/torchrl-*.whl - name: Upload wheel for download - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: torchrl-batch.whl path: dist/*.whl @@ -77,7 +77,7 @@ jobs: run: | python3 -mpip install numpy pytest pytest-cov codecov unittest-xml-reporting pillow>=4.1.1 scipy av networkx expecttest pyyaml - name: Download built wheels - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: torchrl-win-${{ matrix.python_version }}.whl path: wheels