Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels listing and details page #1861

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

mishramonalisha76
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 commented Sep 20, 2024

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@mishramonalisha76 mishramonalisha76 self-assigned this Sep 20, 2024
@mishramonalisha76 mishramonalisha76 linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 20, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1861/
on branch gh-pages at 2024-09-26 17:05 UTC

@rohitmalhotra1420 rohitmalhotra1420 changed the title Channel details page Channels listing and details page Sep 20, 2024
@rohitmalhotra1420
Copy link
Collaborator

rohitmalhotra1420 commented Sep 20, 2024

@mishramonalisha76

  • Skeleton state is not working correctly.
  • Spacing between notifications is not correct.
  • Last notification is not visible
  • Infinite scroll loader not visible for the channel is not visible
  • last channel icon is getting truncated.
  • When i load the channel detail page, initially broken channel img with some data is visible and after that skeleton is visible.
  • The channel icon will also have a border radius and border.
  • Channel icon is shrinking in mobile view.
  • When I change the channel from the left sidebar then the channel address in the URL is not updated.

Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mishramonalisha76 to fix the PR comments.

src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/ChannelDetails.tsx Show resolved Hide resolved
src/modules/channelDetails/ChannelDetails.tsx Outdated Show resolved Hide resolved
src/blocks/textInput/TextInput.tsx Outdated Show resolved Hide resolved
src/common/components/ChannelDetailsCard.tsx Outdated Show resolved Hide resolved
src/common/components/ChannelDetailsCard.tsx Outdated Show resolved Hide resolved
src/queries/hooks/channels/useGetChannelsList.ts Outdated Show resolved Hide resolved
@mishramonalisha76
Copy link
Collaborator Author

The font weight of the channel title in channel listing page doesnot match the one in figma (700 instead of 500 ) @rohitmalhotra1420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the new channels detail page
3 participants