Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt] Move Language Server integration tests to unit #168

Open
glennsarti opened this issue Aug 22, 2019 · 2 comments
Open

[Tech Debt] Move Language Server integration tests to unit #168

glennsarti opened this issue Aug 22, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@glennsarti
Copy link
Contributor

Most of the integration tests for the lang server should be moved to unit tests now that the cache is completely decoupled.

This should mean faster testing.

Also there should an end-to-end kitchen sink test similar to the debug server where we simulate a client and actually test all features.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Mar 30, 2020
@glennsarti
(puppetlabsGH-168) Add acceptance tests
07d4ff4 
This commit adds basic acceptance tests, using an emulated Language Client to
send messages to the Language Server under test. Currently only a single file
is tested.  Later commits will add testing when in a Module or Control Repo.
glennsarti added a commit that referenced this issue Mar 31, 2020
@glennsarti
Merge pull request #229 from glennsarti/add-end-to-end-testing
09cd17f 
(GH-168) Add acceptance tests
@jpogran jpogran added the enhancement New feature or request label Apr 30, 2020
@jpogran
Copy link
Contributor

jpogran commented Apr 30, 2020

@glennsarti was this issue resolved by #229 or does this reflect more work to do?

@glennsarti
Copy link
Contributor Author

There's more to do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpogran @glennsarti