Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pulumi/pkg and pulumi/sdk references are identical #169

Open
t0yv0 opened this issue Oct 2, 2023 · 1 comment
Open

Ensure pulumi/pkg and pulumi/sdk references are identical #169

t0yv0 opened this issue Oct 2, 2023 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 2, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The release/compatibility guarantees on pulumi/pulumi are such that pulumi/pkg and pulumi/sdk Go module reference versions are assumed to match in the consuming code. If they do not match, there might be issues like the code would not compile. Make sure upgrade-provider enforces/respects this invariant.

Affected area/feature

@t0yv0 t0yv0 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Oct 2, 2023
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Oct 2, 2023
@Frassle
Copy link
Member

Frassle commented Oct 2, 2023

Note that tfbridge depends on pkg internals which sometimes have source code breaking changes. So upgrade-provider ought to make sure it doesn't update pkg&sdk beyond what tfbridge is currently testing and building against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants