Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ManagedNodeGroup when creating a LaunchTemplate #1224

Open
JustASquid opened this issue Jul 3, 2024 · 3 comments
Open

Improve ManagedNodeGroup when creating a LaunchTemplate #1224

JustASquid opened this issue Jul 3, 2024 · 3 comments
Labels
kind/enhancement Improvements or new features

Comments

@JustASquid
Copy link
Contributor

JustASquid commented Jul 3, 2024 •
edited
Loading

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In my current use case, I'm trying to implement a Managed Node Group with GPU support. Out of the box this isn't possible, however with a few small tweaks it should be entirely possible.

In addition, during my investigation I noticed a bug where it's not possible to specify the disk size of a managed node group when a custom launch template is created. This is because AWS requires the disk configuration to happen on the launch template, not the diskSize argument in this case.

My suggested implementation is in the PR #1225

Affected area/feature

ManagedNodeGroup
@JustASquid JustASquid added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jul 3, 2024
@JustASquid JustASquid mentioned this issue Jul 3, 2024
Closed
@t0yv0
Copy link
Member

t0yv0 commented Jul 3, 2024

Thanks for looking into this @JustASquid ! At a first glance it looks helpful (CC @flostadler) - my team can help out shepherding the changes through the release process and getting the test cases passing on our CI; one quick request I have is can we split the two issues - one for Managed Node Group with GPU support and one for the diskSize bug, much appreciated!

@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Jul 3, 2024
@JustASquid
Copy link
Contributor Author

JustASquid commented Jul 3, 2024 •
edited
Loading

Cheers @t0yv0 - I have split out the issue and the PR (#1229).

@t0yv0 t0yv0 mentioned this issue Sep 6, 2024
Merged
@flostadler
Copy link
Contributor

This should be resolved once #1339 lands. For now it'll first go into a feature branch dedicated for AL2023 & Bottlerocket support, but that one will land in the main branch within the next ~2 weeks

flostadler added a commit that referenced this issue Sep 6, 2024
@flostadler
Add missing configuration options for Managed Node Groups (#1339)
46f69fe 
The `ManagedNodeGroup` component was missing configuration the other
node groups had.
In detail, that's `amiId`, `gpu` and `userData`.

Those will allow booting specific/custom AMIs, nodes with GPUs or
setting custom user data.
The added E2E tests ensure this works as expected.

Relates to #1224
flostadler added a commit that referenced this issue Sep 13, 2024
@flostadler
Add missing configuration options for Managed Node Groups (#1339)
ca94b1d 
The `ManagedNodeGroup` component was missing configuration the other
node groups had.
In detail, that's `amiId`, `gpu` and `userData`.

Those will allow booting specific/custom AMIs, nodes with GPUs or
setting custom user data.
The added E2E tests ensure this works as expected.

Relates to #1224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Managed Node Group Launch Template Improvements JustASquid/pulumi-eks
3 participants
@t0yv0 @flostadler @JustASquid