Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error highlighting broken in non-Chrome browsers #28

Open
longouyang opened this issue Jun 9, 2016 · 1 comment
Open

Error highlighting broken in non-Chrome browsers #28

longouyang opened this issue Jun 9, 2016 · 1 comment

Comments

@longouyang
Copy link
Member

We need to implement custom stack parsers to handle non-Chrome

@longouyang
Copy link
Member Author

Update: It doesn't look like this will work in Safari, as its error locations are totally wrong (it doesn't do a good job when errors happen in eval'ed code).

Firefox looks a little better but the locations are somewhat off and would be pretty annoying to resolve.

I think it makes more sense to try to solve these issues by manually constructing a webppl stack trace in the trampoline runner, as suggested in probmods/webppl#314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant