Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input fields do not have a length indicator #4

Open
fkusei opened this issue Jun 7, 2024 · 1 comment
Open

input fields do not have a length indicator #4

fkusei opened this issue Jun 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fkusei
Copy link

fkusei commented Jun 7, 2024

This allows users to input very long urls, which in turn leads to HTTP 500 with exception django.db.utils.DataError: value too long for type character varying(20).

pretalx-youtube should either limit the length of the URL or sanitize the url to strip it of all unwanted data before trying to input it into the database.

@fkusei
Copy link
Author

fkusei commented Jun 7, 2024

After reading the code i see that pretalx-youtube should already sanitize the full youtube urls. I suspect that my users used something like https://youtu.be/foobar?utm_medium=share&whatever=foobar, which got sanitized to foobar?utm_medium=share&whatever=foobar. I'll submit a PR to fix this.

@rixx rixx added the bug Something isn't working label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants