Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Move core validators to separate TS library #210

Open
snewcomer opened this issue Dec 28, 2019 · 1 comment
Open

[PROPOSAL] Move core validators to separate TS library #210

snewcomer opened this issue Dec 28, 2019 · 1 comment
Assignees

Comments

@snewcomer
Copy link
Collaborator

Similar to the work that went into ember-changeset, we can extract the core validators to a general typescript/javascript library. This necessitates looking at how we can generalize ember-validators to the greater JS community as well. I suspect this work would be relatively simple and would pair well with the new validated-changeset library.

https://github.com/validated-changeset/validated-changeset

@snewcomer snewcomer self-assigned this Dec 28, 2019
@sandstrom
Copy link
Contributor

While I understand the idea, I actually think it would be better to go in the opposite direction.

For certain open-source projects, it makes sense to abstract things away and turn the project into a building-block for others. But there are also a lot of costs associated with that path. More complexity, more work to maintain, higher threshold for new contributors, etc.

Somewhat related, I'd suggest inlining validated-changeset instead:

#306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants