Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling less on a fs theme #109

Open
djay opened this issue Jun 19, 2016 · 1 comment
Open

compiling less on a fs theme #109

djay opened this issue Jun 19, 2016 · 1 comment

Comments

@djay
Copy link
Member

djay commented Jun 19, 2016

User problem

It's very easy to use the global resources to create a theme in the filesystem and develop it live. Up until you want to compile less. Then suddenly you are told to install grunt and npm and whole lot of other crap.

For example following http://docs.plone.org/adapt-and-extend/theming/barceloneta.html#inheriting-a-new-theme-from-barceloneta requires compiling less.

Currently plone provide a less compiler but only for online themes.

Options

less compile for fs themes

if you see the warning

Warning This is a built-in theme, and cannot be edited.

The compile less button is enabled but breaks if you try to run it on a fs theme. Why is it an "built-in" theme? thats confusing. It should be a read-only theme or something that indicates its not editable online.

Instead we could make this work, create a new css file but not save it. Trying to save would create an error. Then the user can at least copy and paste to the fs.

mix fs and zodb resources

Allow some files to override or exist in the zodb for a fs theme.

save files in fs mode

At least allow the compile to work and save if the server is running in fg mode. A bonus is you get to use the theme editor if you want but still keep the files on disk.

@ebrehault
Copy link
Member

Isn't it a duplicate of plone/Products.CMFPlone#1468 (which I have already fixed, so you can now use the theming editor to compile your FS-based less files)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants