fixed waveshare_esp32_s3_touch_lcd_169 waveshare_esp32_s3_lcd_169 bugs, Added variant for Waveshare ESP32-S3-Zero #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added variant for Waveshare ESP32-S3-Zero
valeros
requested changes
Aug 26, 2024
|
Hi @Y1hsiaochunnn, please review my comments above. |
…2-S3-LCD-1.69 definitions
|
Hi @valeros, |
|
LGTM, the PR will be merged once support for Arduino core v3 is added. |
|
thanks alot |
valeros
approved these changes
Aug 27, 2024
|
Hi @valeros , |
|
@Y1hsiaochunnn As I already mentioned above, the PR will be merged once support for Arduino core v3 is added, see #1225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
fixed waveshare_esp32_s3_touch_lcd_169 waveshare_esp32_s3_lcd_169 bugs,
They're mentioned here:#1436
Added variant for Waveshare ESP32-S3-Zero
Tests scenarios
Untested, pin definition is based on information in Waveshare wiki.
Related links
https://www.waveshare.com/wiki/ESP32-S3-Zero
arduino-esp32 PR espressif/arduino-esp32#10241