Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of time points in metrics returned don't match the number of scans #66

Open
m-miedema opened this issue Sep 4, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working

Comments

@m-miedema
Copy link
Member

Expected Behavior

If one provides the CLI with an -nscans value, one would expect the (convolved) metric to have one value corresponding to each scan.

Actual Behavior

The exported metric (respiratory variance, in this case) contains slightly more values than the number of scans (e.g. -nscans 400, but the _resampled_convolved.1D and _resampled_raw.1D files contain 410 values).

Steps to Reproduce the Problem

1. Run the phys2denoise CLI on a physio object with peaks and troughs
2. Calculate some metrics.
3. Check the number of lines in the output metric files.

Specifications

- Python version: 3.11.4
- phys2denoise version: under development
- Platform: Windows/VSCode

Possible solution

Check how the number of scans are being used in the code during resampling! Where are windows centred? Is the issue coming from the window size? I don't think it's simply the convolution, as the issue is present even in the raw resampled metric. Does the issue change with the number of lags provided?

@m-miedema m-miedema added the Bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant