Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Loguru for better logging #48

Open
smoia opened this issue Nov 3, 2023 · 1 comment
Open

Implement Loguru for better logging #48

smoia opened this issue Nov 3, 2023 · 1 comment
Labels
Enhancement New feature or request Good first issue Good for newcomers

Comments

@smoia
Copy link
Member

smoia commented Nov 3, 2023

So far we're adopting basic logging - 95% of the time that's ok, but for instance the logs are not catching errors, which is annoying for bugfixes.

Loguru might offer a solution, at a very small dependency cost - especially if not on Windows (otherwise two small dependencies more to deal with their terminal).

I think it'd be neat to implement it!

@smoia smoia added Enhancement New feature or request Good first issue Good for newcomers labels Jan 18, 2024
@maestroque
Copy link
Contributor

Existing draft PR: #53

It should entail more or less the changes done in physiopy/peakdet#62, including the logger utility functions.

A point of discussion would be if these utility functions could be transferred in physutils, since they are to be used universally (probably) in the configuration of loguru.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good first issue Good for newcomers
Projects
Status: To Do
Development

No branches or pull requests

2 participants