Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge levinos updates / upgrades #80

Open
levino opened this issue May 2, 2023 · 3 comments
Open

Merge levinos updates / upgrades #80

levino opened this issue May 2, 2023 · 3 comments

Comments

@levino
Copy link
Contributor

levino commented May 2, 2023

Hi there, this is an issue to discuss whether you want to merge my changes. I have created a fork and released a new package. Please also see the demo repo for how to use it.

It has the following advantages:

  • Based on react and jsx
  • storybook enabled
  • Support for translation / multilanguage

Happy to discuss.

@phoinixi
Copy link
Owner

phoinixi commented May 3, 2023

Hey @levino that is great, I wish you brought it up before writing the code. I am working on the same thing, but my idea is a bit different, I had a look at your code and you really put a lot of effort into it. I like the idea, but I will tell you why I am not merging it at this time and also present you my idea and how it differs from yours:

  • I would keep the Rect CV from the original separated to let people still use the old one, I guess it's still valuable
  • The React version I would like to be a base to write any template, not only Stackoverflow style, as soon as I have a first version I will publish it on my GitHub profile

@levino
Copy link
Contributor Author

levino commented May 3, 2023

Do not worry @phoinixi With ChatGPT helping me, it was actually okay. And I needed to have a German CV right now and not in some distant future. So even if my changes are never merged, that is okay.

Also feel free to just take part of my code (for example the .tsx files with the translated components). I guess you will need them anyhow. Also for me it was very important to have the multilanguage feature available. I already thought you might not be interested in this additional complexity so that is also fine.

On the matter of a base for "any" template, I think it is not necessary to have a react template set up but rather provide the building blocks for that, which are:

  • An example cv using all available keys of the schema (an only these! Your code actually supports some keys I could not find in the json schema!)
  • Some nice and easy higher order function that takes a react component and returns the pdfRenderOptions and the render function for resume-cli
  • Maybe some general stuff like proper TypeScript config, build scripts etc.

All of this stuff is in my repo and I invite you to take what you can use from there. Maybe just clone it and throw everything out, that you do not like. Could also be an idea to switch from static css to something like styled-components or tailwind-css but I think that would already be too opinionated for a template / boilerplate theme.

@phoinixi
Copy link
Owner

phoinixi commented May 12, 2023

Some nice and easy higher order function that takes a react component and returns the pdfRenderOptions and the render function for resume-cli

this is the crucial part, your template is valid, I am currently working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants