Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR Process: updateDependencies should check if working copy is clean #329

Open
zepumph opened this issue Jun 19, 2023 · 0 comments
Open
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jun 19, 2023

While doing an MR for https://github.com/phetsims/phet-io-wrappers/issues/519, I accidentally had some working copy changes in perennial-alias instead of perennial for maintenance code. In this case, updateDependencies really failed in a gross way. It got partially through pushing changes and the internal maintenance json state was really messed up. @jonathanolson can we please do a double check here? Similar to how we do it for dev versions:

const dependencies = await getDependencyRepos( repo );
for ( let i = 0; i < dependencies.length; i++ ) {
const dependency = dependencies[ i ];
const isClean = await gitIsClean( dependency );
if ( !isClean ) {
throw new Error( `Unclean status in ${dependency}, cannot deploy` );
}
}

@zepumph zepumph changed the title updateDependencies should check if working copy is clean MR Process: updateDependencies should check if working copy is clean Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants